-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Getters for hyperparameters of Regression and Classification models #306
feat: Getters for hyperparameters of Regression and Classification models #306
Conversation
added getter for the GradientBoosting class + refactored tests
added getter for ElasticNetRegression in Regressor + refactored tests
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1896 1956 +60
=========================================
+ Hits 1896 1956 +60
|
…of-models' into 260-getters-for-hyperparameters-of-models
The IDE complains about missing docstrings for the getter methods. May want to discuss this in a new issue, though. (Or possibly try to automate this in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add docstrings to the property methods which describe the parameter that is returned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The c
parameter for the SupportVectorMachine
also needs a getter. (Both in classification and regression.)
Would be a new issue. |
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01) ### Features * add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264) * Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141) * Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190) * Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260) * improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147) * Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
🎉 This PR is included in version 0.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #260 .
Summary of Changes
Added properties/getters for the hyperparameters of all Regression and Classification models.