Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add empty list testcase for replace_column #353

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

zzril
Copy link
Contributor

@zzril zzril commented Jun 9, 2023

Closes #301.

Summary of Changes

Added a new testcase for replace_column to verify that the method can handle an empty list as argument.

@zzril zzril requested a review from a team as a code owner June 9, 2023 11:57
@lars-reimann
Copy link
Member

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.49s
✅ PYTHON mypy 1 0 1.62s
✅ PYTHON ruff 1 0 0 0.02s
✅ REPOSITORY git_diff yes no 0.0s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #353 (19f9525) into main (d50c5b5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2092      2092           
=========================================
  Hits          2092      2092           

@zzril zzril merged commit 34b9593 into main Jun 9, 2023
@zzril zzril deleted the 301b-empty-list branch June 9, 2023 12:05
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance replace_column to accept a list of new columns
3 participants