test: improve tests for row #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/Safe-DS/Library into 872-improve-tests-for-row-and-_lazyvectorizedrow
…tps://github.com/Safe-DS/Library into 872-improve-tests-for-row-and-_lazyvectorizedrow
Muellersen
requested review from
lars-reimann,
Gerhardsa0,
Marsmaennchen221 and
sibre28
as code owners
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 97.91% 98.12% +0.21%
==========================================
Files 122 122
Lines 6895 6895
==========================================
+ Hits 6751 6766 +15
+ Misses 144 129 -15 ☔ View full report in Codecov by Sentry. |
lars-reimann
changed the title
lars-reimann
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Two lines of _LazyVectorizedRow.__eq__ are missing. Would be nice to cover those as well: https://app.codecov.io/gh/Safe-DS/Library/pull/906/blob/src/safeds/data/tabular/containers/_lazy_vectorized_row.py
Looks perfect otherwise.
lars-reimann
deleted the
872-improve-tests-for-row-and-_lazyvectorizedrow
branch
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #872
Summary of Changes
This pull request improves the tests for rows and lazyVectorizedRows.