fix: allow multiple connections to work with the runner #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WinPlay02
commented
Dec 16, 2023
•
WinPlay02
commented
- fix: allow multiple websocket connections in parallel (custom threading / multiprocessing is initialized before patching for use with gevent)
- feat: send events (during execution) to all connected (listening) websocket connections
- Queries (placeholder_query) is still using a request-response pattern and does not multicast to all connections
- green thread pool size for connections is limited to 8 for now
Use Request-Response for placeholder queries
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
…egistered multiple times test: change tests to always receive pending messages, even when mock connection sent EOF
… into fix-multiconnection
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 368 377 +9
=========================================
+ Hits 368 377 +9 ☔ View full report in Codecov by Sentry. |
…treated as non-test (prefix)
… into fix-multiconnection
lars-reimann
requested changes
Dec 16, 2023
Co-authored-by: Lars Reimann <[email protected]>
lars-reimann
approved these changes
Dec 16, 2023
lars-reimann
pushed a commit
that referenced
this pull request
Jan 26, 2024
## [0.5.0](v0.4.0...v0.5.0) (2024-01-26) ### Features * added json serializer that encodes tables and images ([#29](#29)) ([054cca4](054cca4)), closes [#20](#20) * Memoization ([#38](#38)) ([2a26b48](2a26b48)) * Replace flask with quart ([#43](#43)) ([5520b68](5520b68)), closes [#42](#42) * support placeholder queries that only request a subset of data ([#39](#39)) ([dae57dc](dae57dc)) * update to safe-ds 0.17.1 + server refactor ([#37](#37)) ([1bcad07](1bcad07)) ### Bug Fixes * allow multiple connections to work with the runner ([#31](#31)) ([64685a3](64685a3))
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.