Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace flask with quart #43

Merged
merged 12 commits into from
Jan 26, 2024
Merged

feat: Replace flask with quart #43

merged 12 commits into from
Jan 26, 2024

Conversation

WinPlay02
Copy link
Contributor

Closes #42

Summary of Changes

  • replaces flask with quart
  • rewrite some tests
  • added test against crashing
  • solution should be more scalable as it replaces wsgi with asgi

@WinPlay02 WinPlay02 changed the title Fix linux startup error feat: Replace flask with quart Jan 25, 2024
Copy link

github-actions bot commented Jan 25, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 4 0 0 0.74s
✅ PYTHON mypy 4 0 1.93s
✅ PYTHON ruff 4 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbb23a5) 100.00% compared to head (1514cdb) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          446       449    +3     
=========================================
+ Hits           446       449    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WinPlay02 WinPlay02 marked this pull request as ready for review January 25, 2024 18:21
@WinPlay02 WinPlay02 requested review from a team and lars-reimann as code owners January 25, 2024 18:21
SmiteDeluxe
SmiteDeluxe previously approved these changes Jan 25, 2024
Copy link
Contributor

@SmiteDeluxe SmiteDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with my eda branch and it is working and fixing all my issues! Have not looked at the code for specifics though, @lars-reimann is probably on that!

@lars-reimann lars-reimann merged commit 5520b68 into main Jan 26, 2024
7 checks passed
@lars-reimann lars-reimann deleted the fix-linux-startup-error branch January 26, 2024 12:08
lars-reimann pushed a commit that referenced this pull request Jan 26, 2024
## [0.5.0](v0.4.0...v0.5.0) (2024-01-26)

### Features

* added json serializer that encodes tables and images ([#29](#29)) ([054cca4](054cca4)), closes [#20](#20)
* Memoization ([#38](#38)) ([2a26b48](2a26b48))
* Replace flask with quart ([#43](#43)) ([5520b68](5520b68)), closes [#42](#42)
* support placeholder queries that only request a subset of data ([#39](#39)) ([dae57dc](dae57dc))
* update to safe-ds 0.17.1 + server refactor ([#37](#37)) ([1bcad07](1bcad07))

### Bug Fixes

* allow multiple connections to work with the runner ([#31](#31)) ([64685a3](64685a3))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runner crash on first request on Linux (and maybe others)
4 participants