Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_mtime should handle list of file names, too #88

Closed
lars-reimann opened this issue Apr 17, 2024 · 1 comment · Fixed by #89
Closed

file_mtime should handle list of file names, too #88

lars-reimann opened this issue Apr 17, 2024 · 1 comment · Fixed by #89
Assignees
@lars-reimann
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

ImageList has a method to load many image files at once. It gets a list of file paths (strings). file_mtime should be able to handle this list of strings.

Desired solution

Return a tuple of last modified times.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Apr 17, 2024
@lars-reimann lars-reimann self-assigned this Apr 17, 2024
@lars-reimann lars-reimann mentioned this issue Apr 17, 2024
Merged
WinPlay02 pushed a commit that referenced this issue Apr 17, 2024
@lars-reimann
feat: handle list of filenames in absolute_path and file_mtime (#89)
50d831f 
Closes #88

### Summary of Changes

`file_mtime` and `absolute_path` can now work with a list of strings as
well as a single string. This is needed for function like
`ImageList.from_files` that accept multiple paths.

For now, order matters. Specifying the same paths in a different order
leads to a different memoization key.
lars-reimann pushed a commit that referenced this issue Apr 22, 2024
@semantic-release-bot
chore(release): 0.12.0 [skip ci]
07d4c15 
## [0.12.0](v0.11.0...v0.12.0) (2024-04-22)

### Features

* handle list of filenames in `absolute_path` and `file_mtime` ([#89](#89)) ([50d831f](50d831f)), closes [#88](#88)
* prepare and pool processes ([#87](#87)) ([e5e7011](e5e7011)), closes [#85](#85)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
enhancement 💡 New feature or request released Included in a release
Projects
DSL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle list of filenames in absolute_path and file_mtime Safe-DS/Runner
1 participant
@lars-reimann