feat: handle list of filenames in absolute_path and file_mtime
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-reimann
changed the title
absolute_path and file_mtimeabsolute_path and file_mtime
lars-reimann
changed the title
absolute_path and file_mtimeabsolute_path and file_mtime
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
lars-reimann
force-pushed
the
mtime-for-list-of-files
branch
from
14f2223
to
58f90b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 721 733 +12
=========================================
+ Hits 721 733 +12 ☔ View full report in Codecov by Sentry. |
WinPlay02
approved these changes
Apr 17, 2024
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88
Summary of Changes
file_mtimeandabsolute_pathcan now work with a list of strings as well as a single string. This is needed for function likeImageList.from_filesthat accept multiple paths.For now, order matters. Specifying the same paths in a different order leads to a different memoization key.