feat: Generate stubs for public methods of private classes which are superclasses of public classes #64
Labels
Comments
|
I'd rather propose generating stubs for inherited public methods in the public classes. The stubs are meant to mirror the public interface of a library, which internal classes are not a part of. |
Masara
changed the title
lars-reimann
pushed a commit
that referenced
this issue
Mar 4, 2024
) Closes #64 ### Summary of Changes Now stubs for public methods of internal classes that are being inherited will be created for the classes that inherit them. --------- Co-authored-by: megalinter-bot <[email protected]>
lars-reimann
pushed a commit
that referenced
this issue
Mar 29, 2024
## [0.2.0](v0.1.0...v0.2.0) (2024-03-29) ### Features * Added generation for Safe-DS stubs files ([#33](#33)) ([ab45b45](ab45b45)) * Correct stubs for TypeVars ([#67](#67)) ([df8c5c9](df8c5c9)), closes [#63](#63) * Create stubs for public methods of inherited internal classes ([#69](#69)) ([71b38d7](71b38d7)), closes [#64](#64) * Rework import generation for stubs. ([#50](#50)) ([216e179](216e179)), closes [#38](#38) [#24](#24) [#38](#38) [#24](#24) * Safe-DS stubs also contain docstring information. ([#78](#78)) ([bdb43bd](bdb43bd)) * Stubs are created for referenced declarations in other packages ([#70](#70)) ([522f38d](522f38d)), closes [#66](#66) ### Bug Fixes * Some packages couldn't be analyzed ([#51](#51)) ([fa3d020](fa3d020)), closes [#48](#48) * Stub generation testing and fixing of miscellaneous bugs ([#76](#76)) ([97b0ab3](97b0ab3))
|
🎉 This issue has been resolved in version 0.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
Currently (after PR #50), if public classes inherit from private classes, the stubs for the public class will be generated and reference those private classes, but the private classes won't be generated and are therefore "invisible" for the user.
Desired solution
If a public class inherits from a private class, the private class should generate stubs, too.To do this, we would need to extend the information in the API data so that superclass information also points in the other direction, i.e. we need to find out the subclasses for all classes.The stubs generator should add the public methods of the internal classes to the public classes.
Additional Context
An example test case where the private super class should be generated can be found @
Stub-Generator\tests\data\various_modules_package\aliasing\aliasing_module_1.pyfor the classAliasingModuleClassC.The text was updated successfully, but these errors were encountered: