feat: Correct stubs for TypeVars #67

Masara · 2024-02-25T15:51:51Z

Closes #63

Summary of Changes

TypeVars create correct stubs.

…ypeVar() attributes. Also added test data for typevars

Masara · 2024-02-25T15:53:09Z

@lars-reimann Like I once mentioned here Mypy seems to be unable to parse square brackets right after function and class names. Therefor I had to use a workaround to get the TypeVar information we need for def fun[T](a: T) -> T like functions. The parameter type and return type are seen as "special Any types" in Mypy and I used that information to assume that we've got a TypeVar. You can see the changes concerning this "workaround" here: 9c30988

github-actions · 2024-02-25T15:53:21Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	7	0	0	1.24s
✅ PYTHON	mypy	7		0	5.54s
✅ PYTHON	ruff	7	0	0	0.04s
✅ REPOSITORY	git_diff	yes		no	0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

Masara · 2024-02-25T15:54:56Z

Also it seems like Python 3.11 can't work with the tests containing the def my_fun[T] syntax, what should I do in this case?

lars-reimann · 2024-02-25T16:46:30Z

Also it seems like Python 3.11 can't work with the tests containing the def my_fun[T] syntax, what should I do in this case?

That syntax was introduced in Python 3.12, so that's not surprising. Until mypy supports PEP 695 natively, I'm fine with adding a new issue for that syntax to the backlog. Supporting this is not an urgent feature.

…r-stubs # Conflicts: # src/safeds_stubgen/api_analyzer/_ast_visitor.py

codecov · 2024-02-25T17:39:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (216e179) to head (b2275b6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   98.76%   98.78%   +0.02%     
==========================================
  Files          25       25              
  Lines        2017     2053      +36     
==========================================
+ Hits         1992     2028      +36     
  Misses         25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Masara · 2024-02-25T17:58:38Z

I removed the changes and created issue #68. You can now check the PR.

lars-reimann

Nice work, this requires only minor changes.

...eds_stubgen/stubs_generator/__snapshots__/test_generate_stubs/test_type_var_creation.sdsstub

… generics

Masara · 2024-02-28T14:47:09Z

@lars-reimann I added the changes you requested. It would be nice, if you also look through the new tests at type_var_module.py and maybe suggest some more cases, since I don't know how the stubs would look like and what would be legal and what not.

…r-stubs

Masara · 2024-02-29T15:33:32Z

@lars-reimann I'm done here, you can check this PR now, too.

## [0.2.0](v0.1.0...v0.2.0) (2024-03-29) ### Features * Added generation for Safe-DS stubs files ([#33](#33)) ([ab45b45](ab45b45)) * Correct stubs for TypeVars ([#67](#67)) ([df8c5c9](df8c5c9)), closes [#63](#63) * Create stubs for public methods of inherited internal classes ([#69](#69)) ([71b38d7](71b38d7)), closes [#64](#64) * Rework import generation for stubs. ([#50](#50)) ([216e179](216e179)), closes [#38](#38) [#24](#24) [#38](#38) [#24](#24) * Safe-DS stubs also contain docstring information. ([#78](#78)) ([bdb43bd](bdb43bd)) * Stubs are created for referenced declarations in other packages ([#70](#70)) ([522f38d](522f38d)), closes [#66](#66) ### Bug Fixes * Some packages couldn't be analyzed ([#51](#51)) ([fa3d020](fa3d020)), closes [#48](#48) * Stub generation testing and fixing of miscellaneous bugs ([#76](#76)) ([97b0ab3](97b0ab3))

lars-reimann · 2024-03-29T13:16:37Z

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

v0.2.0
GitHub release

Your semantic-release bot 📦🚀

Masara added 5 commits February 25, 2024 13:17

Adjusted snapshot test files for typevar stubs

47c437f

Added another test case for typevar stubs

979def4

Added typevar stubs test module and separate snapshots

1b77b68

TypeVar stub creation now works with type vars if they are existing T…

79913eb

…ypeVar() attributes. Also added test data for typevars

Now "def func[T]" like TypeVars can also be analyzed. Adjusted tests.

9c30988

Masara requested a review from a team as a code owner February 25, 2024 15:51

Masara linked an issue Feb 25, 2024 that may be closed by this pull request

feat: Analyzing TypeVar Variables and their usage and generating correct stubs #63

Closed

Masara and others added 2 commits February 25, 2024 16:57

Linter fixes

a90a8af

style: apply automated linter fixes

78802d0

Masara added 2 commits February 25, 2024 18:36

Removed changes for 'def func[T]' TypeData from commit 9c30988

1f89f5a

Merge remote-tracking branch 'origin/63-typevar-stubs' into 63-typeva…

206338f

…r-stubs # Conflicts: # src/safeds_stubgen/api_analyzer/_ast_visitor.py

Masara mentioned this pull request Feb 25, 2024

feat: Support PEP 695 TypeVars syntax for the stubs generator. #68

Open

lars-reimann requested changes Feb 25, 2024

View reviewed changes

Masara added 3 commits February 26, 2024 00:25

TypeVar names are now in camelCase in stubs

aade9cb

(WIP) Added a TypeVar test case for a class with type parameters.

12469d5

Fixed how classes and their methods generate stubs if the classes use…

d3ef10f

… generics

Masara and others added 7 commits February 29, 2024 13:44

Added more snapshot tests for type var and adjusted the variance tests

8e01d2d

snapshot test update

fec471a

Fixed variance generation in stubs

c469f78

style: apply automated linter fixes

5c1e9f3

type vars in function stubs now can also have upper bound

fafa108

Merge remote-tracking branch 'origin/63-typevar-stubs' into 63-typeva…

480b744

…r-stubs

linter fix

68531d4

style: apply automated linter fixes

b2275b6

lars-reimann approved these changes Feb 29, 2024

View reviewed changes

lars-reimann merged commit df8c5c9 into main Feb 29, 2024
8 checks passed

lars-reimann deleted the 63-typevar-stubs branch February 29, 2024 16:22

lars-reimann added the released Included in a release label Mar 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Correct stubs for TypeVars #67

feat: Correct stubs for TypeVars #67

Masara commented Feb 25, 2024

Masara commented Feb 25, 2024

github-actions bot commented Feb 25, 2024 •

edited

Loading

Masara commented Feb 25, 2024

lars-reimann commented Feb 25, 2024

codecov bot commented Feb 25, 2024 •

edited

Loading

Masara commented Feb 25, 2024

lars-reimann left a comment

Masara commented Feb 28, 2024

Masara commented Feb 29, 2024

lars-reimann commented Mar 29, 2024

feat: Correct stubs for TypeVars #67

feat: Correct stubs for TypeVars #67

Conversation

Masara commented Feb 25, 2024

Summary of Changes

Masara commented Feb 25, 2024

github-actions bot commented Feb 25, 2024 • edited Loading

🦙 MegaLinter status: ✅ SUCCESS

Masara commented Feb 25, 2024

lars-reimann commented Feb 25, 2024

codecov bot commented Feb 25, 2024 • edited Loading

Codecov Report

Masara commented Feb 25, 2024

lars-reimann left a comment

Choose a reason for hiding this comment

Masara commented Feb 28, 2024

Masara commented Feb 29, 2024

lars-reimann commented Mar 29, 2024

github-actions bot commented Feb 25, 2024 •

edited

Loading

codecov bot commented Feb 25, 2024 •

edited

Loading