Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stubs are created for referenced declarations in other packages #70

Merged
merged 30 commits into from
Mar 3, 2024
Merged

feat: Stubs are created for referenced declarations in other packages #70

merged 30 commits into from
Mar 3, 2024

Conversation

Masara
Copy link
Contributor

@Masara Masara commented Feb 29, 2024

Closes #66

Summary of Changes

Now limited stubs are created for imported classes from other packages.

@Masara Masara requested a review from a team as a code owner February 29, 2024 13:58
@Masara Masara linked an issue Feb 29, 2024 that may be closed by this pull request
feat: Stubs must be created for referenced declarations in other packages #66
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.75s
✅ PYTHON mypy 2 0 5.15s
✅ PYTHON ruff 2 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (78df1cd) to head (b003965).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   98.78%   98.80%   +0.02%     
==========================================
  Files          25       25              
  Lines        2053     2098      +45     
==========================================
+ Hits         2028     2073      +45     
  Misses         25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Masara
Copy link
Contributor Author

Masara commented Mar 2, 2024

@lars-reimann I changed the stubs-generator the way you said and refactored the tests, are the tests like this all right or should I still try to get the file names with glob like you mentioned here?

@Masara
Copy link
Contributor Author

Masara commented Mar 2, 2024

Also, you can merge this PR first.

@Masara
test fix
e048738
@Masara
Merge remote-tracking branch 'origin/66-limited-stubs-for-referenced-…
e91cb44 
…declarations' into 66-limited-stubs-for-referenced-declarations
@Masara
Copy link
Contributor Author

Masara commented Mar 2, 2024

@lars-reimann I changed the tests, now all stubs files should be checked

@Masara Masara mentioned this pull request Mar 2, 2024
Merged
@lars-reimann
Copy link
Member

Yep, looks great this way and should be easier to extend later on.

lars-reimann
lars-reimann approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@lars-reimann lars-reimann merged commit 522f38d into main Mar 3, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 66-limited-stubs-for-referenced-declarations branch March 3, 2024 09:29
lars-reimann pushed a commit that referenced this pull request Mar 29, 2024
@semantic-release-bot
chore(release): 0.2.0 [skip ci]
81b9b1d 
## [0.2.0](v0.1.0...v0.2.0) (2024-03-29)

### Features

* Added generation for Safe-DS stubs files ([#33](#33)) ([ab45b45](ab45b45))
* Correct stubs for TypeVars ([#67](#67)) ([df8c5c9](df8c5c9)), closes [#63](#63)
* Create stubs for public methods of inherited internal classes ([#69](#69)) ([71b38d7](71b38d7)), closes [#64](#64)
* Rework import generation for stubs. ([#50](#50)) ([216e179](216e179)), closes [#38](#38) [#24](#24) [#38](#38) [#24](#24)
* Safe-DS stubs also contain docstring information. ([#78](#78)) ([bdb43bd](bdb43bd))
* Stubs are created for referenced declarations in other packages ([#70](#70)) ([522f38d](522f38d)), closes [#66](#66)

### Bug Fixes

* Some packages couldn't be analyzed ([#51](#51)) ([fa3d020](fa3d020)), closes [#48](#48)
* Stub generation testing and fixing of miscellaneous bugs ([#76](#76)) ([97b0ab3](97b0ab3))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Stubs must be created for referenced declarations in other packages
3 participants
@Masara @lars-reimann @megalinter-bot