This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
(FIX) Retain Cycle Between SoftAskView and Manager #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexApriamashvili
requested review from
tanveer-muhammad,
ricardosarmiento and
sprejjs
and removed request for
a team
AlexApriamashvili
force-pushed
the
fix-retain-cycle-between-soft-ask-view-and-manager
branch
from
b5c9c33
to
27345c1
Compare
codingrhythm
approved these changes
Feb 24, 2022
ricardosarmiento
approved these changes
Feb 24, 2022
sprejjs
approved these changes
Feb 24, 2022
tanveer-muhammad
approved these changes
Feb 24, 2022
rensilveira
approved these changes
Feb 24, 2022
AlexApriamashvili
deleted the
fix-retain-cycle-between-soft-ask-view-and-manager
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library had a retention cycle between
SoftAskVIewdescendants and their manager (Camera,Contacts, etc)This PR introduces the resolution for that cycle.
managerentity is expected to be an instance of a class (as it is now) and referred weakly from theSoftAskView.