Skip to content

Commit

Permalink
Merge branch 'gen-1516-table_update_cohort_specific' of github.com:Sa…
Browse files Browse the repository at this point in the history
…ge-Bionetworks/genie-bpc-pipeline into gen-1516-table_update_cohort_specific

merge upstream changes
  • Loading branch information
danlu1 committed Oct 24, 2024
2 parents 3e11436 + a7ff3ab commit f0e9cb8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
git checkout develop
git checkout -b gen-1234-{feature-here}
```
4. Once you have made your additions or changes, make sure you write tests and run the [comparison scripts](https://github.com/Sage-Bionetworks/Genie_processing/blob/create_generalized_comparison_script/utility_scripts/compare_between_two_synapse_entities.py) to ensure changes are expected.
4. Once you have made your additions or changes, make sure you write tests and run [comparison scripts](https://github.com/Sage-Bionetworks/Genie_processing/blob/ed806d163fa4063a84920483e8ada21ea4b6cf47/README.md#comparisons-between-two-synapse-entities) to ensure changes are expected.
5. At this point, you have only created the branch locally, you need to push this to your fork on GitHub.

```
git add your file
git commit -m"your commit information"
git push --set-upstream origin SYNPY-1234-{feature-here}
git push --set-upstream origin gen-1234-{feature-here}
```
6. Create a pull request from the feature branch to the develop branch. An Github action will be triggered to create a docker image for the branch, you can check it [here](https://github.com/Sage-Bionetworks/genie-bpc-pipeline/pkgs/container/genie-bpc-pipeline).
6. Create a pull request from the feature branch to the develop branch. When changes are made to `script/<module_folder_name>` (only applies to scripts/references and scripts/table_updates for now), a Github action will be triggered to create a docker image for the branch, you can check it [here](https://github.com/Sage-Bionetworks/genie-bpc-pipeline/pkgs/container/genie-bpc-pipeline).

## Nextflow Pipeline contribution

Expand Down Expand Up @@ -56,4 +56,4 @@ Defaults for process resource requirements (CPUs / memory / time) for a process

### Testing
1. To test locally, you can’t use ghcr.io/sage-bionetworks/docker_image_name locally directly. You will need to pull the docker image to local and test with it.
2. To test on Sequra, go to the test_bpc_pipeline, edit the pipeline by pointing it to your feature branch then update. Doing this will allow you to select parameters from the dropdown menu directly.
2. To test on Sequra, go to the test_bpc_pipeline, edit the pipeline by pointing it to your feature branch then update. Doing this will allow you to select parameters from the dropdown menu directly.

0 comments on commit f0e9cb8

Please sign in to comment.