[ETL-635] Add dispatch-to-raw SQS queue #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
reviewed
Jul 8, 2024
| template: | ||
| path: sqs-queue.yaml | ||
| parameters: | ||
| MessageRetentionPeriod: "1209600" |
There was a problem hiding this comment.
Odd that these are all strings, but is this an artifact of sceptre?
There was a problem hiding this comment.
It's Cloudformation CLI behavior. Parameters must be string, even when they are defined in the template as Number, as is the case here.
If I try to use an integer:
"Parameter validation failed:\nInvalid type for parameter Parameters[0].ParameterValue, value: 1209600, type: <class 'int'>, valid types: <class 'str'>"
BryanFauble
approved these changes
Jul 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.