Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETL-670] Update code to paginate over all results #128

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. There is a maximum of 1000 objects that can return from a single call to list_objects_v2

Solution:

  1. Using a pagination to loop over all objects in the bucket/prefix

Testing:

  1. To review the action runs

@BryanFauble BryanFauble requested a review from a team as a code owner July 16, 2024 19:12
Copy link

sonarcloud bot commented Jul 16, 2024

Copy link
Contributor

@philerooski philerooski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works 👍 You might have also invoked the CLI directly

aws s3 rm s3://<bucket-name>/<path> --exclude <exclusion-pattern> --recursive

@BryanFauble BryanFauble merged commit bedc391 into main Jul 16, 2024
18 checks passed
@BryanFauble BryanFauble deleted the etl-670-paginate-over-objects branch July 16, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants