Fix Snowflake cleanup #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
reviewed
Jul 17, 2024
| @@ -52,7 +51,7 @@ jobs: | |||
| run: | | |||
| snow sql \ | |||
| -q " | |||
| SET safe_environment_identifier = (SELECT REPLACE('$GITHUB_REF_NAME', '-', '_')); | |||
| SET safe_environment_identifier = (SELECT REPLACE('${{ github.event.ref }}', '-', '_')); | |||
There was a problem hiding this comment.
I haven't looked very closely, but we will want to be careful to not bring down main / dev databases and tables. Only for feature branches in the future.
There was a problem hiding this comment.
That could only happen if we delete the main branch, which would be catastrophic in other ways. But no need to compound the damage. I added a conditional on this job just in case.
rxu17
reviewed
Jul 17, 2024
|
rxu17
reviewed
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not use the right reference