Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-534] Add develop s3 Ingestion bucket #25

Merged
merged 12 commits into from
Mar 22, 2023

Conversation

thomasyu888
Copy link
Member

@thomasyu888 thomasyu888 commented Mar 21, 2023

Purpose: This creates the ingestion bucket for pilot data. (SYNAPSE_INPUT_SHARED_BUCKET)

This is the first bucket in the ingress pipeline for RECOVER project. This will be the bucket that the digital health team uses to deposit pilot data.

@thomasyu888 thomasyu888 requested a review from a team as a code owner March 21, 2023 00:42
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 00:48 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 00:54 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 00:55 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 01:03 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 01:04 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 changed the title Add attached input bucket Ingestion bucket Mar 21, 2023
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 01:50 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 01:52 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 changed the title Ingestion bucket Add develop Ingestion bucket Mar 21, 2023
@thomasyu888 thomasyu888 changed the title Add develop Ingestion bucket Add develop s3 Ingestion bucket Mar 21, 2023
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 01:59 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 02:00 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 02:00 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 02:02 — with GitHub Actions Inactive
GrantAccess:
- 'arn:aws:iam::325565585839:root' # Required ARN for a synapse bucket
- 'arn:aws:sts::526515999252:assumed-role/AWSReservedSSO_S3ExternalCollab_40c062f682e7f3f5/[email protected]'
- 'arn:aws:iam::621233246578:role/EES3-RK-6A32F45B-RECOVER' # QA ARN role for Care Evolution
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove access to the Care Evolution role.

Copy link
Contributor

@rxu17 rxu17 Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what we discussed regarding the dev ingestion bucket, should we just remove the care evolution access now?

@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 18:54 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 18:55 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 19:57 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 19:59 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 22:40 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 22:42 — with GitHub Actions Inactive
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment

GrantAccess:
- 'arn:aws:iam::325565585839:root' # Required ARN for a synapse bucket
- 'arn:aws:sts::526515999252:assumed-role/AWSReservedSSO_S3ExternalCollab_40c062f682e7f3f5/[email protected]'
- 'arn:aws:iam::621233246578:role/EES3-RK-6A32F45B-RECOVER' # QA ARN role for Care Evolution
Copy link
Contributor

@rxu17 rxu17 Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on what we discussed regarding the dev ingestion bucket, should we just remove the care evolution access now?

@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 23:32 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 temporarily deployed to develop March 21, 2023 23:34 — with GitHub Actions Inactive
@thomasyu888 thomasyu888 changed the title Add develop s3 Ingestion bucket [IBCDPE-534] Add develop s3 Ingestion bucket Mar 22, 2023
@thomasyu888 thomasyu888 merged commit 92baddc into main Mar 22, 2023
@thomasyu888 thomasyu888 deleted the create-dev-attach-bucket branch March 22, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants