Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-381] Grant Synapse access to dev parquet bucket #37

Merged
merged 2 commits into from
Apr 4, 2023
Merged

[ETL-381] Grant Synapse access to dev parquet bucket #37

merged 2 commits into from
Apr 4, 2023

Conversation

philerooski
Copy link
Contributor

@philerooski philerooski commented Apr 3, 2023 •
edited
Loading

  • Synapse granted permissions to dev parquet bucket (by modifying existing bucket stack) and owner.txt stack created
  • Added functionality to setup_external_storage script to be able to use Synapse authentication token stored in SSM parameter.
  • I tested it on this Synapse folder: https://www.synapse.org/#!Synapse:syn51284492

@philerooski philerooski requested a review from a team as a code owner April 3, 2023 22:39
@philerooski philerooski temporarily deployed to develop April 3, 2023 22:40 — with GitHub Actions Inactive
rxu17
rxu17 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thomasyu888
thomasyu888 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM - Thanks for testing this! we can definitely give this script to people on SysBio when they need to link the pre-ETL bucket to a project. That said, they probably have a script already.

@philerooski philerooski merged commit a41457f into main Apr 4, 2023
@philerooski philerooski deleted the etl-381 branch April 4, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxu17 rxu17 rxu17 approved these changes

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philerooski @thomasyu888 @rxu17