[ETL-407] Add integration tests for prod/staging #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
reviewed
Jul 5, 2023
| @@ -10,6 +10,8 @@ env: | |||
| PYTHON_VERSION: 3.9 | |||
| DEV_INPUT_BUCKET: recover-dev-input-data | |||
| DEV_PROCESSED_BUCKET: recover-dev-processed-data | |||
| PROD_INPUT_BUCKET: recover-input-data | |||
| PROD_PROCESSED_BUCKET: recover-processed-data | |||
There was a problem hiding this comment.
No, I was just mirroring the lines above. Probably we will never need it.
rxu17
approved these changes
Jul 5, 2023
| @@ -313,3 +315,41 @@ jobs: | |||
|
|
|||
| - name: Deploy sceptre stacks to staging on prod | |||
| run: pipenv run sceptre --var "namespace=staging" launch prod --yes | |||
|
|
|||
|
|
|||
| integration-test-staging: | |||
There was a problem hiding this comment.
Should we have a section for if: github.ref_name == 'main' since we'd be only deploying when a feature gets merged into main?
There was a problem hiding this comment.
Nevermind, it requires sceptre-deploy-staging which already has that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submits all production data to the staging namespace's pipeline if the github ref is main.