[ETL-492] Update Glue table schemas to match crawler findings #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxu17
reviewed
Jul 6, 2023
There was a problem hiding this comment.
Will this schema change for the production data affect test runs with the pilot data given that the pilot data doesn't have these updated fields/new fields?
There was a problem hiding this comment.
The changes here fall into a few different categories:
- New fields -- these changes don't affect the pilot data. The fields aren't in the data, so they aren't included in the parquet.
- Overdue changes -- In some cases, specifically in
EnrolledParticipants.EventDatesandSymptomLog.Value, we hadn't updated the types after the transformations we do to these fields in the S3 to JSON job. They are string in the original data, but they're string-encoded JSON. We load them as dicts and write them as JSON objects in the ndjson, so the schemas reflect the object structure now.
So the pilot data isn't affected by these changes. It's fair to ask why was nothing breaking before because of the overdue changes? TBH, I don't think Glue entirely respects the data types we use in our tables. In some cases it just uses whatever data type it detects and can load the data with.
There was a problem hiding this comment.
@thomasyu888 see my comment above
thomasyu888
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.