Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETL-585] Upgrade worker type for HealthKitV2Samples and FitbitIntradayCombined #95

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[ETL-585] Upgrade worker type for HealthKitV2Samples and FitbitIntradayCombined #95

merged 1 commit into from
Dec 14, 2023

Conversation

philerooski
Copy link
Contributor

No description provided.

@philerooski philerooski requested a review from a team as a code owner December 14, 2023 19:40
thomasyu888
thomasyu888 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 This looks good, but should the "WorkerType" just be configurable and be something you can pass through a configuration instead of this?

@philerooski
Copy link
Contributor Author

🔥 This looks good, but should the "WorkerType" just be configurable and be something you can pass through a configuration instead of this?

@thomasyu888 We use Jinja in the template to dynamically generate each of these jobs based on the data types we have available in src/glue/resources/table_columns.yaml. So the configuration file specifies the properties shared in common by all jobs, but any type-specific logic needs to go in the template.

@philerooski philerooski merged commit 154c5f9 into main Dec 14, 2023
14 checks passed
@philerooski philerooski deleted the etl-585 branch December 14, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philerooski @thomasyu888