Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORTALS-3195 - Migrate AD Knowledge Portal to react-router v6 #1285

Open
wants to merge 2 commits into
base: PORTALS-3195
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/portals/adknowledgeportal/src/App.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Load variable_overrides first, so correct values for variables will be applied to the rest of the styles
@use './config/style/variable_overrides';

@use '@sage-bionetworks/synapse-portal-framework/src/style/App';
@use '@sage-bionetworks/synapse-portal-framework/style/App';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Vite config was updated to improve hot-module reloading & imports from the synapse-portal-framework package, so SCSS imports had to update to accomodate this.


// style_overrides should be last to ensure its styles have highest priority
@use './config/style/style_overrides';
51 changes: 51 additions & 0 deletions apps/portals/adknowledgeportal/src/config/navbarConfig.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import { NavbarConfig } from '@sage-bionetworks/synapse-portal-framework/components/navbar/Navbar'

export const navbarConfig: NavbarConfig = {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each portal will have this new config file

routes: [
{
name: 'Explore',
path: '/Explore',
children: [
{ name: 'Programs', path: '/Explore/Programs' },
{ name: 'Projects', path: '/Explore/Projects' },
{ name: 'Studies', path: '/Explore/Studies' },
{ name: 'Data', path: '/Explore/Data' },
{ name: 'Publications', path: '/Explore/Publications' },
{ name: 'People', path: '/Explore/People' },
{
name: 'Experimental Models',
path: '/Explore/Experimental Models',
},
{
name: 'Computational Tools',
path: '/Explore/Computational Tools',
},
{
name: 'Target Enabling Resources',
path: '/Explore/Target Enabling Resources',
},
{ name: 'Results', path: '/Explore/Results' },
],
},
{
name: 'Analysis Platforms',
path: '/Analysis Platforms',
},
{
name: 'Data Access',
path: '/Data Access',
},
{
name: 'Contribute',
path: '/Contribute',
},
{
name: 'News',
path: 'https://news.adknowledgeportal.org/',
},
{
name: 'Help',
path: 'https://help.adknowledgeportal.org/apd/',
},
],
}

This file was deleted.

Loading