PORTALS-3270: Tool detail page spacing between lines is too large #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-hodgson
reviewed
Nov 1, 2024
| className="SubsectionRowRenderer__item" | ||
| role="table" | ||
| > | ||
| <Typography | ||
| variant={ | ||
| columnNameIsSectionTitle ? 'sectionTitle' : 'subsectionHeader' | ||
| } | ||
| role="heading" | ||
| role="subHeading" |
There was a problem hiding this comment.
Is "subHeading" a valid ARIA role? Heading is... https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/heading_role
For the spacing change, would it be appropriate to define sx properties in this Typography component instead of relying on the css?
There was a problem hiding this comment.
@jay-hodgson subHeading is indeed not a valid ARIA role. I just reverted it back to "heading". If I use sx I have to use !important to override the global styles but with inline css, I can override it!
jay-hodgson
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://sagebionetworks.jira.com/browse/PORTALS-3270?atlOrigin=eyJpIjoiODI4OTQwMzhjYmNhNDZkNGE5NzQzODg1NmE2NDA0ZGYiLCJwIjoiaiJ9