PORTALS-3299: proposed solution for oauth sign in app when prompt is … #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
reviewed
Oct 29, 2024
Comment on lines
52
to
54
| setTimeout(() => { | ||
| window.location.assign(href) | ||
| }, 10) |
There was a problem hiding this comment.
Because I mistakenly thought that cookies.set() was an async operation so I wanted to queue this redirect! I will remove the setTimeout
nickgros
reviewed
Oct 29, 2024
nickgros
reviewed
Oct 29, 2024
nickgros
approved these changes
Oct 29, 2024
Co-authored-by: Nick Grosenbacher <[email protected]>
Co-authored-by: Nick Grosenbacher <[email protected]>
nickgros
reviewed
Oct 29, 2024
| cookies.set(ACCOUNT_SITE_PROMPTED_FOR_LOGIN_COOKIE_KEY, 'true', { | ||
| path: '/', | ||
| expires: expireDate, | ||
| domain: hostname.endsWith('.synapse.org') ? 'synapse.org' : undefined, |
There was a problem hiding this comment.
This may not work on dev (which is OK for now, since we don't have a dev OAuth app or accounts site)
nickgros
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set to login