SWC-7064 - Logic for direct S3 upload #1345
Conversation
| "@aws-sdk/client-s3": "^3.682.0", | ||
| "@aws-sdk/lib-storage": "^3.682.0", |
There was a problem hiding this comment.
In SWC, we are using v2 of the AWS client. Upgrade to v3, which is modular and actively maintained.
| rest.post( | ||
| `${backendOrigin}${FILE}/externalFileHandle`, | ||
| async (req, res, ctx) => { | ||
| const request = await req.json<ExternalFileHandleInterface>() | ||
|
|
||
| const response: SynapseApiResponse<ExternalFileHandleInterface> = { | ||
| ...request, | ||
| id: uniqueId(), | ||
| etag: 'fake-etag', | ||
| createdBy: MOCK_USER_ID.toString(), | ||
| createdOn: new Date().toISOString(), | ||
| modifiedOn: new Date().toISOString(), | ||
| } | ||
|
|
||
| return res(ctx.status(201), ctx.json(response)) | ||
| }, | ||
| ), |
There was a problem hiding this comment.
Simple handler for POST /externalFileHandle service
| @@ -0,0 +1,9 @@ | |||
| export type FileUploadArgs = { | |||
There was a problem hiding this comment.
This type represents the shared arguments for useDirectUploadToS3 in this PR, and another hook to use Synapse multipart upload coming in a later PR.
| import { Upload } from '@aws-sdk/lib-storage' | ||
| import { uploadToS3 } from './UploadToS3' | ||
|
|
||
| jest.mock('@aws-sdk/lib-storage', () => { |
There was a problem hiding this comment.
I originally tried to mock the S3 HTTP API using Mock Service Worker. Unfortunately, I ran into issues where the AWS SDK required methods on Blob that JSDOM does not polyfill, and replacing the Blob polyfill caused errors in other tests because other JSDOM polyfills rely on using their Blob polyfill.
packages/synapse-react-client/src/synapse-queries/file/useDirectUploadToS3.test.ts
Outdated
Show resolved
Hide resolved
No description provided.