Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidebar): ensure that component renders correctly at 400% zoom #7061

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(sidebar): ensure that component renders correctly at 400% zoom #7061

merged 1 commit into from
Nov 11, 2024

Conversation

DipperTheDan
Copy link
Contributor

fixes #7035

Proposed behaviour

Screenshot 2024-11-06 at 13 41 18

Current behaviour

Screenshot 2024-11-06 at 13 41 07

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

  • Ensure no styling regressions with Sidebar component.
  • Zoom in to 400% with the default example and Sidebar should be correctly displayed on screen.

@DipperTheDan DipperTheDan self-assigned this Nov 6, 2024
@DipperTheDan DipperTheDan marked this pull request as ready for review November 7, 2024 15:13
@DipperTheDan DipperTheDan requested review from a team as code owners November 7, 2024 15:13
@DipperTheDan DipperTheDan force-pushed the FE-6880_400%-zoomies-bug-with-sidebar branch from dc605f4 to 4750909 Compare November 11, 2024 14:39
@DipperTheDan DipperTheDan merged commit 6107261 into master Nov 11, 2024
25 checks passed
@DipperTheDan DipperTheDan deleted the FE-6880_400%-zoomies-bug-with-sidebar branch November 11, 2024 14:52
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 144.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusbercea-sage dariusbercea-sage dariusbercea-sage approved these changes

@damienrobson-sage damienrobson-sage damienrobson-sage approved these changes

@edleeks87 edleeks87 edleeks87 approved these changes

Assignees

@DipperTheDan DipperTheDan

Labels
Passed QA Passed Review Passed UX QA released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar content out of screen when max zoom in
6 participants
@DipperTheDan @carbonci @edleeks87 @damienrobson-sage @dariusbercea-sage @harpalsingh