Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove roundedCornersOptOut feature flag #7070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: remove roundedCornersOptOut feature flag #7070

wants to merge 1 commit into from

Conversation

tomdavies73
Copy link
Contributor

@tomdavies73 tomdavies73 commented Nov 11, 2024 •
edited
Loading

Proposed behaviour

This update removes the `focusRedesignOptOut feature flag, consumers can no longer opt out of the rounded corners styling.

Current behaviour

Currently, consumers can opt out of the rounded corners styling.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@tomdavies73 tomdavies73 self-assigned this Nov 11, 2024
@tomdavies73 tomdavies73 requested review from a team as code owners November 11, 2024 15:56
@tomdavies73 tomdavies73 marked this pull request as draft November 11, 2024 16:39
@tomdavies73 tomdavies73 marked this pull request as ready for review November 11, 2024 16:46
@tomdavies73 tomdavies73 changed the title feat: remove roundedCornersOptOut feature flag **WIP** feat: remove roundedCornersOptOut feature flag Nov 12, 2024
damienrobson-sage
damienrobson-sage previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@damienrobson-sage damienrobson-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tomdavies73
feat: remove roundedCornersOptOut feature flag
941e112 
This update removes the `focusRedesignOptOut feature flag, consumers can no longer opt out of the
rounded corners styling

BREAKING CHANGE: The `focusRedesignOptOut` feature flag has been removed completely. If passed to
the `CarbonProvider` it will need to be removed, if consumers are also relying on previous
non-rounded corners styling this will also no longer be available.
@tomdavies73 tomdavies73 marked this pull request as draft November 12, 2024 16:00
@tomdavies73 tomdavies73 marked this pull request as ready for review November 12, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DipperTheDan DipperTheDan DipperTheDan approved these changes

@damienrobson-sage damienrobson-sage damienrobson-sage approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@tomdavies73 tomdavies73

Labels
DO NOT MERGE No UX QA Required Pending QA Pending Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomdavies73 @damienrobson-sage @DipperTheDan