Fix http socks close

SagerNet · Jun 17, 2024 · d9f2559 · d9f2559
1 parent b8736cc
commit d9f2559
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/protocol/http/client.go b/protocol/http/client.go
@@ -80,6 +80,7 @@ func (c *Client) DialContext(ctx context.Context, network string, destination M.
 	}
 	if c.host != "" && c.host != destination.Fqdn {
 		if c.path != "" {
+			_ = conn.Close()
 			return nil, E.New("Host header and path are not allowed at the same time")
 		}
 		request.Host = c.host
@@ -90,6 +91,7 @@ func (c *Client) DialContext(ctx context.Context, network string, destination M.
 	if c.path != "" {
 		err = URLSetPath(request.URL, c.path)
 		if err != nil {
+			_ = conn.Close()
 			return nil, err
 		}
 	}

diff --git a/protocol/socks/client.go b/protocol/socks/client.go
@@ -149,6 +149,7 @@ func (c *Client) DialContext(ctx context.Context, network string, address M.Sock
 		}
 		return NewAssociatePacketConn(udpConn, address, tcpConn), nil
 	}
+	_ = tcpConn.Close()
 	return nil, os.ErrInvalid
 }
 
@@ -181,5 +182,6 @@ func (c *Client) BindContext(ctx context.Context, address M.Socksaddr) (net.Conn
 		}
 		return tcpConn, nil
 	}
+	_ = tcpConn.Close()
 	return nil, os.ErrInvalid
 }