Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python isort to pre-commit #295

Open
jbampton opened this issue Nov 5, 2024 · 2 comments
Open

Add Python isort to pre-commit #295

jbampton opened this issue Nov 5, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@jbampton
Copy link
Member

jbampton commented Nov 5, 2024

No description provided.

@jbampton jbampton added this to the November milestone Nov 5, 2024
@jbampton jbampton self-assigned this Nov 5, 2024
@jbampton jbampton added the bug Something isn't working label Nov 5, 2024
@jbampton
Copy link
Member Author

jbampton commented Nov 5, 2024

Blocked:

Salam$ make check
pre-commit install
pre-commit installed at .git/hooks/pre-commit
pre-commit run --all-files
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/abe/.cache/pre-commit/repoh4gmipbo/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/abe/.cache/pre-commit/repoh4gmipbo
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error
      
      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/abe/.cache/pre-commit/repoh4gmipbo/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/abe/.cache/pre-commit/repoh4gmipbo/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/abe/.cache/pre-commit/repoh4gmipbo/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-l8ukuwi1/overlay/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 42, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-l8ukuwi1/overlay/lib/python3.10/site-packages/poetry/core/factory.py", line 60, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - data.extras.pipfile_deprecated_finder[2] must match pattern ^[a-zA-Z-_.0-9]+$
          
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed
    
    × Encountered error while generating package metadata.
    ╰─> See above for output.
    
    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/abe/.cache/pre-commit/pre-commit.log
make: *** [Makefile:3: check] Error 3

Similar error message here:

zylon-ai/private-gpt#942

@BDadmehr0
Copy link
Contributor

#297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants