-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add isort in pre-commit #297
base: main
Are you sure you want to change the base?
Conversation
Please change
to:
|
The process is isort, and even if I change this file in the way you suggest, isort will revert it to its previous state unless we exclude this file from being checked by isort. |
Cool. how? What is the thinking methodology behind this sorting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks
The reason why isort writes |
Okay good, thanks. |
➜ Salam git:(main) ✗ pre-commit run isort --all-files [WARNING] Unexpected key(s) present on https://github.com/adrienverge/yamllint => yamllint: env isort (python)...........................................................Passed