Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNNDFU: Update Nordic Android & iOS dependencies #2

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

manualexSP
Copy link

@manualexSP manualexSP commented Jan 21, 2023

  • Upgrade android.tools.build:gradle from 4.0.1 -> 7.2.1
  • Upgrade no.nordicsemi.android:dfu from 2.0.1 -> 2.3.0
  • Upgrade iOSDFULibrary from 4.11.1 -> 4.12.0

@manualexSP
Copy link
Author

@anees17861 & @fabiendem Hey guys, since I saw that you were active on this fork I want to let you know that we are testing some new updates in the next couple of weeks we will release those changes.
So if you have some time to test these changes on your project to be sure that we won't spoil anything on your side, that would be great.

@fabiendem
Copy link

Thanks for the heads up @manualexSP !
I will share this with my colleagues.

@anees17861
Copy link

Thanks for notifying @manualexSP
Will try to test it out as soon as possible.
Any app side changes that I should be doing?

@anees17861
Copy link

PS @manualexSP
Thank you for continuously maintaining this library. Saved me a ton of time trying to figure out the bridging

@manualexSP
Copy link
Author

manualexSP commented Jan 25, 2023

@fabiendem I don't think so.
We had a crash on the app when we were doing a dfu update if we were targeting SDK 31+ (for android 12/13)
And starting this year google has not been allowing releases without targeting SDK 31+ so we did those changes and from what we tested on our side, everything looks good.
The only change on our side it was

        compileSdkVersion = 30 -> 31
        targetSdkVersion = 30 -> 31

@LucasHimelfarb
Copy link

@manualexSP thanks a lot for your contribution!!!

@manualexSP
Copy link
Author

Probably we will merge this PR on Monday

@manualexSP manualexSP merged commit b720d3d into master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants