Add configurable stop mode #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another, more simple solution would be to just remove |
# Conflicts: # src/components/audio_source.rs # src/components/bundles.rs
* Refactor AudioSource to allow stop_mode configuration * Refactor AudioSource to allow stop_mode configuration * Update examples to new API * Remove overcomplicated builder * Remove StopMode defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution to #72 as it would now be possible to configure a new sound with stop_mode = None. Then you could despawn the entity immediately and the sound would play until the end.
Maybe a better solution would be to create a new enum instead of the
Option<StopMode>. That way we can give it a more appropriate name and avoid the necessity for users to importlibfmod::StopMode. LMK