Remove dependency on bevy_audio feature #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously included the
bevy_audio
feature to access the AudioSinkPlayback trait. I don't know anymore why I did that. I have no use case and no-one else has voiced a use case. I guess my intention was compatibility, but when using FMOD, my guess is that most users replace their entire audio solution anyways.In case we need some sort of compatibility, we should find a different solution in the future, i.e. an adapter between
bevy_fmod
andbevy_audio
but as a separate struct.This had the side effect, that in a project that doesn't use the
bevy_audio
feature, it still was implicitly introduced, and its structs exposed bybevy::prelude:*
.As
bevy_fmod
uses some names for its structs that are also present inbevy_audio
. This creates a name clash that can currently only be resolved with explicit import or import aliasing.Closes #85