Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on bevy_audio feature #88

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Salzian
Copy link
Owner

@Salzian Salzian commented Aug 5, 2024

We previously included the bevy_audio feature to access the AudioSinkPlayback trait. I don't know anymore why I did that. I have no use case and no-one else has voiced a use case. I guess my intention was compatibility, but when using FMOD, my guess is that most users replace their entire audio solution anyways.

In case we need some sort of compatibility, we should find a different solution in the future, i.e. an adapter between bevy_fmod and bevy_audio but as a separate struct.

This had the side effect, that in a project that doesn't use the bevy_audio feature, it still was implicitly introduced, and its structs exposed by bevy::prelude:*.

As bevy_fmod uses some names for its structs that are also present in bevy_audio. This creates a name clash that can currently only be resolved with explicit import or import aliasing.

Closes #85

@Salzian Salzian added the bug Something isn't working label Aug 5, 2024
@Salzian Salzian added this to the v0.6 milestone Aug 5, 2024
@Salzian Salzian requested a review from GitGhillie August 5, 2024 17:34
@Salzian Salzian self-assigned this Aug 5, 2024
Copy link
Collaborator

@GitGhillie GitGhillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On vacation right now so I can't test it but it looks good to me. I'll leave an approval but if you want me to test it that will take a week or two

@Salzian Salzian merged commit b312790 into main Aug 5, 2024
@Salzian Salzian deleted the remove-bevy-audio-dependency branch August 5, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider disambiguating names with Bevy's prelude
2 participants