"Fixes GoogleContainerTools#2752"

--no-push and remote caching dont work with each other
Samarth08 · Apr 22, 2024 · 64f0256 · 64f0256
1 parent a9062b9
commit 64f0256
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/executor/push.go b/pkg/executor/push.go
@@ -399,7 +399,7 @@ func pushLayerToCache(opts *config.KanikoOptions, cacheKey string, tarPath strin
 	}
 	cacheOpts := *opts
 	cacheOpts.TarPath = ""   // tarPath doesn't make sense for Docker layers
-	cacheOpts.NoPush = false // we want to push cached layers
+	cacheOpts.NoPush = opts.NoPush // we don't want to push cached layers if no push is specified
 	cacheOpts.Destinations = []string{cache}
 	cacheOpts.InsecureRegistries = opts.InsecureRegistries
 	cacheOpts.SkipTLSVerifyRegistries = opts.SkipTLSVerifyRegistries