Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft : [EdgeTPU] Adding Options for Edge TPU Compiler to CfgEditor #1625

Closed
wants to merge 22 commits into from

Conversation

Hyeon-Uk
Copy link
Contributor

@Hyeon-Uk Hyeon-Uk commented Sep 5, 2023

For #1621

This Draft is to add options for Edge TPU Compiler to cfgEditor

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk [email protected]

Hyeon-Uk and others added 10 commits September 5, 2023 12:24
- Clicking the EdgeTPU radio button in the import step now expands a dedicated component for configuring EdgeTPU Compiler options.
- Added options within the cfgeditor.html file to support customization of EdgeTPU Compiler settings.

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
* [EdgeTPU] Add EdgeTPU Input Path to CfgEditor

- Implemented the ability to input the path as either text or via a dialog.
- Disabled the output path functionality.
- Modified the output path to append "_edgetpu" as a postfix to the name of the .tflite file received from the input path.

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
* [EdgeTPU] Add EdgeTPU Advanced Option Show Operations to cfgEditor

- Implemeted Show Operations checkbox on editor
- When the box checked, add a new one-import-edgetpu option named show_operation
- Add information about this option in help class

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>

---------

Co-authored-by: 김현욱 <[email protected]>
* [EdgeTPU] Implement Help checkbox in CfgEditor

- add Help checkbox
- add question codicon
- add click event to help checkbox
- append cfg attribute if you click the checkbox, "Help"

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
- rename 'addEPostfixToFileName' to 'addPostfixToFileName'
- adjust default value on addPostfixToFileName's postfix param

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
- Implemented Search Delegate Option
- The type of view is checkbox and the data type is boolean
- Question Mark Codicon has a help message

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
this commit is for separating branches

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
- separating branch

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
- separating base branch

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
This reverts commit cba2709.

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
Hyeon-Uk and others added 7 commits September 6, 2023 12:00
 [EdgeTPU] Fix Input Path code
- rename 'addEPostfixToFileName' to 'addPostfixToFileName'
- adjust default value on addPostfixToFileName's postfix param
- if filePath is blank, return blank
- Fix the bug where the postfix is incorrectly attached when an extension is not provided.
- add default value

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
…tor (#6)

* [EdgeTPU] Add EdgeTPU Advanced Option Min Runtime Version to cfgEditor

- Implemented Min Runtime Version dropdown on View
- There are only 5 versions in Documents
- On 'help', add description about compiler and runtime version
- Not Styled Version, Only function

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>

---------

Co-authored-by: 김현욱 <[email protected]>
)

- Implemented Search Delegate Option
- The type of view is checkbox and the data type is boolean
- Question Mark Codicon has a help message

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
- Fix bug caused by unclosed parentheses in index.js

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
…itor (#17)

- add text field to input intermediateTensors
- add eventListener to intermediateTensors input tag

ONE-vscode-DCO-1.0-Signed-off-by: Hyeon-Uk <[email protected]>
@dayo09
Copy link
Contributor

dayo09 commented Sep 6, 2023

(GIF Updated; I didn't know that the gif didn't work)
0907-ssafy

I think it's well-done :-D Thanks a lot.

One thing that we should consider is : 'how to make it on/off'?

We'd better define a module on/off flag.
It's the bad practice but I suggest a way that you temporarily define a global variable, or a as an environment variable in extension context, etc.

So that we can gather our parts together and easily modulize later.

* [EdgeTPU] Add Advanced Option 'Delegate Search Step' to cfgEditor

- Implemented Delegate Search Step in cfgEditor with number type of vscode-text-field
- This option is depending on 'Search Delegate'.
- When 'Search Delegate' is checked, the text-field for this option is shown.
- When 'Search Delegate' is unchecked, the text-field for this option is not shown and this opiton is also removed on the cfg text file.

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
* [EdgeTPU] HotFix Remove Advanced Option 'Help'
- All options have codicon that describes each options.
- Therefore, this option is useless.

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
- Intermediate_tensors placeholder type : semi-colon to comma

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
[EdgeTPU] HotFix Duplicate Error Resolve

- 'Intermediate_tensors' and 'Search Delegate' cannot be duplicated.
- If one of them is selected, the other option's information is deleted.

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
…27)

- We assume all advanced options are the optional that means the compiler will be run even there is no value in the options.
- Remove the word 'Optional' after Show Operations, Min Runtime Version, Search Delegate and Delegate Search Step

ONE-vscode-DCO-1.0-Signed-off-by: hohee-hee <[email protected]>
@Hyeon-Uk
Copy link
Contributor Author

From now on, we will separate the EdgeTPU-related Editor function from the existing cfgEditor code and modularize it.

@dayo09
Copy link
Contributor

dayo09 commented Sep 15, 2023

Go for it !! :-D

@profornnan profornnan added DRAFT Something like playground NO MERGE labels Sep 21, 2023
@dayo09 dayo09 closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DRAFT Something like playground NO MERGE SSAFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants