Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EdgeTPU] Add shell script for the prerequisites #1667

Merged
merged 3 commits into from
Sep 23, 2023
Merged

[EdgeTPU] Add shell script for the prerequisites #1667

merged 3 commits into from
Sep 23, 2023

Conversation

profornnan
Copy link
Contributor

@profornnan profornnan commented Sep 21, 2023 •
edited
Loading

Add the shell script that add PPA to get edgetpu-compiler package for EdgeTPU

ONE-vscode-DCO-1.0-Signed-off-by: profornnan [email protected]

Related: #1621 #1628

@profornnan
[EdgeTPU] Add shell script for the prerequisites
21670dd 
Add the shell script that add PPA to get edgetpu-compiler package for EdgeTPU

ONE-vscode-DCO-1.0-Signed-off-by: profornnan <[email protected]>
@jyoungyun
Copy link
Collaborator

Please add @Samsung/one-vscode as a reviewer. :)

@jyoungyun jyoungyun requested a review from a team September 21, 2023 06:13
jyoungyun
jyoungyun reviewed Sep 21, 2023
View reviewed changes
script/prerequisitesForGetEdgeTPUToolchain.sh Outdated
curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add -
echo "deb https://packages.cloud.google.com/apt coral-edgetpu-stable main" | sudo tee /etc/apt/sources.list.d/coral-edgetpu.list

apt-get update -yqq
Copy link
Collaborator

@jyoungyun jyoungyun Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apt-get update -yqq
sudo apt-get update -yqq

This command needs sudo privilege. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you~!! I have added sudo privilege in the new commit :)

@profornnan profornnan requested a review from a team September 21, 2023 06:20
@profornnan
[EdgeTPU] Add sudo privilege to prerequisites script
5859771 
Add sudo privilege to prerequisites script for edgetpu toolchain

ONE-vscode-DCO-1.0-Signed-off-by: profornnan <[email protected]>
@dayo09
Copy link
Contributor

dayo09 commented Sep 22, 2023

Doesn't this script need executable permission? prerequisitesForGetOneToolchain.sh has executable permission.

-rw-rw-r--  1 dayo dayo  331  9월 22 13:22 prerequisitesForGetEdgeTPUToolchain.sh
-rwxrwxr-x  1 dayo dayo  184  9월 14 16:55 prerequisitesForGetToolchains.sh
-rwxrwxr-x  1 dayo dayo  933  9월  5 19:18 sdbSpecList.sh

@profornnan
[EdgeTPU] Add executable permission to prerequisites script
c7f7ed5 
Add executable permission to prerequisites script for edgetpu toolchain

ONE-vscode-DCO-1.0-Signed-off-by: profornnan <[email protected]>
dayo09
dayo09 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@profornnan
Copy link
Contributor Author

Thank you!! :D

jyoungyun
jyoungyun approved these changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun merged commit c2866c7 into Samsung:ssafy/2023 Sep 23, 2023
hohee-hee pushed a commit to SSDC-onE-FiVE/ONE-vscode that referenced this pull request Sep 25, 2023
@profornnan @hohee-hee
[EdgeTPU] Add shell script for the prerequisites (Samsung#1667)
f6a84ad
hohee-hee pushed a commit to SSDC-onE-FiVE/ONE-vscode that referenced this pull request Sep 27, 2023
@profornnan @hohee-hee
[EdgeTPU] Add shell script for the prerequisites (Samsung#1667)
9223084
@rhqjatn2398 rhqjatn2398 deleted the feat/edgetpu-toolchain branch October 5, 2023 11:09
@dayo09 dayo09 mentioned this pull request Nov 1, 2023
Open
dayo09 pushed a commit to dayo09/ONE-vscode that referenced this pull request Nov 2, 2023
@profornnan @dayo09
[EdgeTPU] Add shell script for the prerequisites (Samsung#1667)
71c39db 
ONE-vscode-DCO-1.0-Signed-off-by: Dayoung Lee <[email protected]>
dayo09 pushed a commit to dayo09/ONE-vscode that referenced this pull request Nov 2, 2023
@profornnan @dayo09
[EdgeTPU] Add shell script for the prerequisites (Samsung#1667)
54af4fa 
This commit adds a shell script for getting prerequisties.

ONE-vscode-DCO-1.0-Signed-off-by: profornnan <[email protected]>
@dayo09 dayo09 mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyoungyun jyoungyun jyoungyun approved these changes

@dayo09 dayo09 dayo09 approved these changes

@rhqjatn2398 rhqjatn2398 Awaiting requested review from rhqjatn2398

Assignees

@rhqjatn2398 rhqjatn2398

@profornnan profornnan

Labels
SSAFY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@profornnan @jyoungyun @dayo09 @rhqjatn2398