Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/test] Remove nnpackage and modelfile options #13569

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

hseok-oh
Copy link
Contributor

@hseok-oh hseok-oh commented Aug 1, 2024

This commit removes "--nnpackage" and "--modelfile" options from onert_run and onert_train test drivers.
They can be handled on last parameter without option automatically.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]

This commit removes "--nnpackage" and "--modelfile" options from `onert_run` and `onert_train` test drivers.
They can be handled on last parameter without option automatically.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Aug 1, 2024
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for a few suggestions. :)

tests/tools/onert_train/README.md Outdated Show resolved Hide resolved
tests/tools/onert_train/README.md Outdated Show resolved Hide resolved
tests/tools/onert_train/README.md Outdated Show resolved Hide resolved
tests/tools/onert_train/README.md Outdated Show resolved Hide resolved
Co-authored-by: Jiyoung Giuliana Yun <[email protected]>
@hseok-oh hseok-oh requested a review from jyoungyun August 1, 2024 05:54
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@glistening glistening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 28de5e3 into Samsung:master Aug 1, 2024
9 checks passed
@hseok-oh hseok-oh deleted the remove_option_pkg_file branch August 1, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants