Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert] Generate BackPropAccumulator only if necessary #13570

Conversation

ragmani
Copy link
Contributor

@ragmani ragmani commented Aug 1, 2024

This commit changes BackPropAccumulators to be generated only if the correspoding dispoable tensors exist.

ONE-DCO-1.0-Signed-off-by: ragmani [email protected]

@ragmani ragmani added the PR/ready for review It is ready to review. Please review it. label Aug 1, 2024
@ragmani ragmani requested a review from a team August 1, 2024 03:25
@ragmani ragmani added PR/NO MERGE Please don't merge. I'm still working on this :) and removed PR/ready for review It is ready to review. Please review it. labels Aug 1, 2024
@ragmani
Copy link
Contributor Author

ragmani commented Aug 1, 2024

waiting for #13571

This commit changes BackPropAccumulators to be generated only if the correspoding dispoable tensors exist.

ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
@ragmani ragmani force-pushed the onert/training/generate_backprop_acc_only_need branch from 0a3e9f9 to 74ed77e Compare August 2, 2024 08:27
@ragmani
Copy link
Contributor Author

ragmani commented Aug 2, 2024

rebased

@ragmani ragmani added PR/ready for review It is ready to review. Please review it. and removed PR/NO MERGE Please don't merge. I'm still working on this :) labels Aug 2, 2024
Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoungyun jyoungyun requested a review from a team August 5, 2024 01:51
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit 62eaa3d into Samsung:master Aug 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants