[luci-interpreter] Support RoPE operation #14104
Conversation
|
@jinevening |
| { | ||
| for (int32_t i2 = 0; i2 < i2_n; ++i2) | ||
| { | ||
| for (int32_t i3 = 0; i3 < i3_n / 2; ++i3_n) |
There was a problem hiding this comment.
i3_n is const int32_t. How is this updated?
There was a problem hiding this comment.
i made a mistake while changing the variable name.
i will update it. thanks
There was a problem hiding this comment.
CI just passed this code, which means that this code is not compiled. You should add RoPE to compiler/luci-interpreter/pal/linux/KernelsToBuild.lst.
There was a problem hiding this comment.
i prepared another PR.
as you comment, it would be better to make it together.
i will make PR including kernelsToBuild.lst and loader.
ys44kim
force-pushed
the
rope/luci-interpreter
branch
2 times, most recently
from
e3950c1
to
6726d24
Compare
ys44kim
changed the title
ys44kim
force-pushed
the
rope/luci-interpreter
branch
2 times, most recently
from
d43184f
to
b221cb9
Compare
This commit supports RoPE for luci-interpreter ONE-DCO-1.0-Signed-off-by: youngsik kim [email protected]
ys44kim
force-pushed
the
rope/luci-interpreter
branch
from
b221cb9
to
82d5df7
Compare
| void RoPE::configure() | ||
| { | ||
| LUCI_INTERPRETER_CHECK(input()->shape().num_dims() == 4); | ||
|
|
There was a problem hiding this comment.
from seanshpark,
the head size (dim(3)) of input and the size of sin/cos should be the same.
so, it is necessary to check the condition here.
This Commit adds check condition for sin/cos table ONE-DCO-1.0-Signed-off-by: youngsik kim <[email protected]>
This commit adds test case to check sin/cos table ONE-DCO-1.0-Signed-off-by: youngsik kim <[email protected]>
This commits add test case to check rope mode ONE-DCO-1.0-Signed-off-by: youngsik kim [email protected]
ys44kim
force-pushed
the
rope/luci-interpreter
branch
from
53983ce
to
a52fb0c
Compare
This commit supports RoPE kernel in luci-interpreter
ONE-DCO-1.0-Signed-off-by: youngsik kim [email protected]
draft : #13978
issue : #13972