[NUI] Fix some svace issues. #5344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huayongxu
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
wb0716
approved these changes
Jun 20, 2023
huayongxu
force-pushed
the
fix-svace-devel-1
branch
from
83d2408
to
edd239e
Compare
hinohie
approved these changes
Jun 20, 2023
| @@ -54,7 +54,7 @@ internal VertexBuffer(global::System.IntPtr cPtr, bool cMemoryOwn) : base(cPtr, | |||
|
|
|||
| public void SetData<VertexType>(VertexType[] vertices) where VertexType : struct | |||
| { | |||
| if (null == vertices) | |||
| if (null == vertices || vertices.Length == 0) | |||
There was a problem hiding this comment.
Minor. Could you please add comments about exception (line 52) that we can throw exception if certices length is zero?
huayongxu
force-pushed
the
fix-svace-devel-1
branch
from
edd239e
to
bc33039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
WID:56638093 An overflow in the arithmetic expression sizeof(IntPtr) * textures.Count which is used in Marshal.AllocHGlobal(sizeof(IntPtr) * textures.Count) may occur. Please use checked arithmetic to throw IntegerOverflowException in case of overflow instead of possible memory damage
WID:56646651 The iteration number in loop with condition i < _parts.Count - 1 is off by one
WID:56638091 An overflow in the arithmetic expression structSize * vertices.Length which is used in Marshal.AllocHGlobal(structSize * vertices.Length) may occur. Please use checked arithmetic to throw IntegerOverflowException in case of overflow instead of possible memory damage
API Changes