Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Write comments for Matrix #5358

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Jun 26, 2023

Write some comments for Matrix / Matrix3 class.

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 2, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix Tizen.NUI.Matrix::Identity()

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::IDENTITY()

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::Assign(Tizen.NUI.Matrix)

Copy link
Contributor

@everLEEst everLEEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

Write some comments for Matrix / Matrix3 class

Signed-off-by: Eunki, Hong <[email protected]>
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 3, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix Tizen.NUI.Matrix::Identity()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Rotation,Tizen.NUI.Matrix)

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::IDENTITY()

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::Assign(Tizen.NUI.Matrix)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Matrix,Tizen.NUI.Rotation)

@hinohie hinohie changed the title [NUI][WIP] White comments for Matrix [NUI] Write comments for Matrix Jun 29, 2023
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 3, Removed: 6, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix Tizen.NUI.Matrix::Identity()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Rotation,Tizen.NUI.Matrix)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::Identity()

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::IDENTITY()

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix Tizen.NUI.Matrix::Assign(Tizen.NUI.Matrix)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.Matrix Tizen.NUI.Matrix::op_Multiply(Tizen.NUI.Matrix,Tizen.NUI.Rotation)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::IDENTITY()

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::Assign(Tizen.NUI.Matrix)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.Matrix3 Tizen.NUI.Matrix3::Assign(Tizen.NUI.Matrix3)

@jmmhappy
Copy link
Contributor

Looks Good To Me

@hinohie hinohie merged commit 0182bd1 into Samsung:DevelNUI Jun 30, 2023
3 checks passed
@hinohie hinohie deleted the comment_matrix branch June 30, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants