Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tts] Add new internal API for TTS synthesized PCM #5526

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

stom-hwang
Copy link
Contributor

Description of Change

Add internal method for playing mode and synthesized pcm event.

@github-actions github-actions bot added the API10 Platform : Tizen 7.0 / TFM: tizen10.0 label Sep 1, 2023
@stom-hwang stom-hwang changed the title Add internal method for playing mode and synthesized pcm event [Tts] Add internal method for playing mode and synthesized pcm event Sep 1, 2023
@stom-hwang stom-hwang changed the title [Tts] Add internal method for playing mode and synthesized pcm event [Tts] Add new internal API for TTS synthesized PCM Sep 1, 2023
@TizenAPI-Bot
Copy link
Collaborator

Build Error:

Tizen.Uix.Tts/SynthesizedPcmEventArgs.cs(24,6): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/SynthesizedPcmEventArgs.cs(24,6): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/SynthesizedPcmEventArgs.cs(24,22): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(237,6): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(237,6): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(237,22): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(255,6): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(255,6): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(255,22): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(273,6): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(273,6): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(273,22): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(739,10): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(739,10): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(739,26): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(982,10): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(982,10): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]
Tizen.Uix.Tts/TtsClient.cs(982,26): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Uix.Tts/Tizen.Uix.Tts.csproj]

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 19, Removed: 0, Changed: 0

Added

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Uix.Tts.AudioType

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.AudioType Tizen.Uix.Tts.AudioType::RawS16

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.AudioType Tizen.Uix.Tts.AudioType::RawU8

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Uix.Tts.PlayingMode

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.PlayingMode Tizen.Uix.Tts.PlayingMode::ByClient

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.PlayingMode Tizen.Uix.Tts.PlayingMode::ByService

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Uix.Tts.SynthesizedPcmEvent

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.SynthesizedPcmEvent Tizen.Uix.Tts.SynthesizedPcmEvent::Continue

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.SynthesizedPcmEvent Tizen.Uix.Tts.SynthesizedPcmEvent::Fail

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.SynthesizedPcmEvent Tizen.Uix.Tts.SynthesizedPcmEvent::Finish

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.Uix.Tts.SynthesizedPcmEvent Tizen.Uix.Tts.SynthesizedPcmEvent::Start

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Uix.Tts.SynthesizedPcmEventArgs

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Byte[] Tizen.Uix.Tts.SynthesizedPcmEventArgs::Data()

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.Uix.Tts.SynthesizedPcmEventArgs::SampleRate()

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.Uix.Tts.SynthesizedPcmEventArgs::UtteranceId()

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Uix.Tts.AudioType Tizen.Uix.Tts.SynthesizedPcmEventArgs::AudioType()

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Uix.Tts.SynthesizedPcmEvent Tizen.Uix.Tts.SynthesizedPcmEventArgs::EventType()

+ /// <privilege>http://tizen.org/feature/speech.synthesis</privilege
+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.Uix.Tts.PlayingMode Tizen.Uix.Tts.TtsClient::PlayingMode()

+ /// <since_tizen>11</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.Uix.Tts.SynthesizedPcmEventArgs> Tizen.Uix.Tts.TtsClient::SynthesizedPcm

/// </summary>
/// <since_tizen> 11 </since_tizen>
[EditorBrowsable(EditorBrowsableState.Never)]
public class SynthesizedPcmEventArgs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should inherit from System.EventArgs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking. I think other event args in Tts do not inherit the System.EventAgrs.
So Is it okay to fix it all other classes without ACR?

Copy link
Contributor

@urmain urmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!!

Copy link
Contributor

@syeonholic syeonholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@stom-hwang stom-hwang merged commit 3d07bfb into Samsung:API10 Sep 7, 2023
3 checks passed
@stom-hwang stom-hwang deleted the INTER/255 branch September 7, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API10 Platform : Tizen 7.0 / TFM: tizen10.0 Internal API Changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants