[NUI] AddPrecompileShader() for precompile shader #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscholb
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.VisualFactory::AddPrecompileShader(Tizen.NUI.PropertyMap)
|
Seoyeon2Kim
reviewed
Sep 13, 2024
| /// VisualFactory.Instance.UsePreCompiledShader(); | ||
| /// | ||
| /// <param name="option">The map contains the shader option for precompiling.</param> | ||
| [EditorBrowsable(EditorBrowsableState.Never)] |
There was a problem hiding this comment.
If this method really needs the boolean return, could you leave a description about the return meaning as well?
Like,
Suggested change
| [EditorBrowsable(EditorBrowsableState.Never)] | |
| /// <return>True if the pre-compiled shader is added, otherwise false.</return> | |
| [EditorBrowsable(EditorBrowsableState.Never)] |
There was a problem hiding this comment.
감사합니다.
리뷰 남겨주신대로 수정 완료했습니다 👍
taehyub
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
(example)
PropertyMap imageShader = new PropertyMap();
imageShader.Add("shaderType", new PropertyValue("image"));
imageShader.Add("shaderOption", new PropertyValue(new PropertyMap().Add("ROUNDED_CORNER", new PropertyValue(true))
.Add("MASKING", new PropertyValue(true))));
PropertyMap textShader = new PropertyMap();
textShader.Add("shaderType", new PropertyValue("text"));
VisualFactory.Instance.AddPrecompileShader(imageShader);
VisualFactory.Instance.AddPrecompileShader(textShader);
VisualFactory.Instance.UsePreCompiledShader();
<param name="option">The map contains the shader option for precompiling.</param>
<return>True if the pre-compiled shader is added, otherwise false.</return>Sample 까지 API에 첨부해주셔서 잘 이해가 됩니다 👍
큰 구현이었는데 수고많으셨습니다!
tscholb
force-pushed
the
240902_devel
branch
from
ea561c5
to
297df25
Compare
hinohie
approved these changes
Sep 13, 2024
Seoyeon2Kim
approved these changes
Sep 13, 2024
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.VisualFactory::AddPrecompileShader(Tizen.NUI.PropertyMap)
|
|
@taehyub, @Seoyeon2Kim , @hinohie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
shader precompile 시 원하는 옵션을 추가할 수 있는 기능입니다.
아래 패치들이 반영되어야 정상동작합니다.
Visual Factory Refactoring
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/315396/
Precompile option 추가 기능
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/316058/
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/315273/
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/316877/
[NUI] AddPrecompileShader() for precompile shader #6298
npatch shader 추가
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/316798/
CanclePrecompile 관련 버그 수정 패치
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/316966/
API Changes