[WebAuthn] Add WebAuthn API #6311

feedop · 2024-09-05T13:19:13Z

Description of Change

Add C# API for Web Authentication including public API, interop and documentation.

API Changes

ACR: TCSACR-597

TizenAPI-Bot · 2024-09-05T13:23:37Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 178, Removed: 0, Changed: 0

src/Tizen.Security.WebAuthn/Interop/Interop.Libraries.cs

wiertel · 2024-09-12T11:54:51Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/AuthenticationExt.cs

+namespace Tizen.Security.WebAuthn
+{
+    /// <summary>
+    /// Authenticator extension


Please ensure that description ends with a period. In C# API period is almost always there, one exception is single word enum value description (if all of them in that enum are very short).

wiertel · 2024-09-12T11:56:18Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/AuthenticationExt.cs

+    /// <summary>
+    /// Authenticator extension
+    /// </summary>
+    /// <since_tizen> 9 </since_tizen>


I see in this PR since_tizen with values 4, 7, 9. It should be 12 in all newly added items.

wiertel · 2024-09-12T12:01:53Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/AuthenticationExt.cs

+        /// Extension Identifier defined in the following registry.
+        /// https://www.iana.org/assignments/webauthn/webauthn.xhtml#webauthn-extension-ids


It would be best to use links in the text like this:

Suggested change

/// Extension Identifier defined in the following registry.

/// https://www.iana.org/assignments/webauthn/webauthn.xhtml#webauthn-extension-ids

/// Extension Identifier defined in the <a href="https://www.iana.org/assignments/webauthn/webauthn.xhtml#webauthn-extension-ids">WebAuthn Extension Identifiers registry</a>.

but for now lets just replace period with a colon ("registry. https..." -> "registry: https...")

wiertel · 2024-09-12T12:02:40Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/AuthenticationSelCri.cs

+        /// Initializes a new instance of the <see cref="AuthenticationSelCri"/> class.
+        /// </summary>
+        /// <since_tizen> 9 </since_tizen>
+        /// <param name="attachment">Authenticator attachment modality</param>


please use periods in params as well

wiertel · 2024-09-12T12:04:19Z

src/Tizen.Security.WebAuthn/doc/api/Tizen.Security.WebAuthn.md

@@ -0,0 +1,25 @@
+---
+uid: Tizen.Security.WebAuthm


typo, uid must match the fully qualified namespace exactly

wiertel · 2024-09-12T12:04:34Z

src/Tizen.Security.WebAuthn/doc/api/Tizen.Security.WebAuthn.md

+remarks: *content
+---
+## Overview
+It provides an Authenticator cclass containing methods for creating public key-based credentials


wiertel · 2024-09-12T12:12:11Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/PubkeyCredCreationOptions.cs

+        /// Initializes a new instance of the <see cref="PubkeyCredCreationOptions"/> class.
+        /// </summary>
+        /// /// <since_tizen> 9 </since_tizen>
+        /// <param name="rp">Contains a name and an identifier for the Relying Party responsible for the request</param>


that's a lot of parameters, if they are optional they maybe specify default values in the method signature so the user will be able to skip those that are not used,
see https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments?redirectedfrom=MSDN#optional-arguments

Done. I made the same change to PubkeyCredRequestOptions.

TizenAPI-Bot · 2024-09-12T12:43:03Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 178, Removed: 5, Changed: 3

Internal API Changed

Added: 4, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.DragAndDrop/DragAndDropEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.Window,System.String,Tizen.NUI.DragAndDrop/DragAndDropWindowEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Collections.Generic.Dictionary`2<System.String,System.String> Tizen.NUI.DragData::DataMap

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String[] Tizen.NUI.DragEvent::MimeTypes()

TizenAPI-Bot · 2024-09-16T13:51:00Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 197, Removed: 20, Changed: 3

Internal API Changed

Added: 19, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.DragAndDrop/DragAndDropEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.Window,System.String,Tizen.NUI.DragAndDrop/DragAndDropWindowEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Collections.Generic.Dictionary`2<System.String,System.String> Tizen.NUI.DragData::DataMap

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String[] Tizen.NUI.DragEvent::MimeTypes()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockStateChangedEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLock Tizen.System.PowerLockStateChangedEventArgs::PowerLockType()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockState Tizen.System.PowerLockStateChangedEventArgs::PowerLockState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateChangeRequestEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.System.PowerStateChangeRequestEventArgs::Retval()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateChangeRequestEventArgs::PowerState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::NextState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::PrevState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerStateWaitEventArgs::TransitionReason()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerTransientStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientState Tizen.System.PowerTransientStateWaitEventArgs::TransientState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerTransientStateWaitEventArgs::TransitionReason()

TizenAPI-Bot · 2024-09-17T14:05:22Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 197, Removed: 20, Changed: 3

Internal API Changed

Added: 19, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.DragAndDrop/DragAndDropEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.Window,System.String,Tizen.NUI.DragAndDrop/DragAndDropWindowEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Collections.Generic.Dictionary`2<System.String,System.String> Tizen.NUI.DragData::DataMap

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String[] Tizen.NUI.DragEvent::MimeTypes()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockStateChangedEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLock Tizen.System.PowerLockStateChangedEventArgs::PowerLockType()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockState Tizen.System.PowerLockStateChangedEventArgs::PowerLockState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateChangeRequestEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.System.PowerStateChangeRequestEventArgs::Retval()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateChangeRequestEventArgs::PowerState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::NextState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::PrevState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerStateWaitEventArgs::TransitionReason()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerTransientStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientState Tizen.System.PowerTransientStateWaitEventArgs::TransientState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerTransientStateWaitEventArgs::TransitionReason()

wiertel · 2024-09-18T11:00:05Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/Authenticator.cs

+        /// <since_tizen> 12 </since_tizen>
+        /// <remarks>This method must be called before other methods are called.</remarks>
+        /// <feature>http://tizen.org/feature/security.webauthn</feature>
+        /// <param name="apiVersionNumber">API version number to set. Use <see cref="ApiVersionNumber"/> as an input.</param>


what does this mean? User should take the ApiVersionNumber and pass it here all the time? I would prefer if things were automatic. Who provides the value of the property? Is there sensible default value?

Changed it so that API version is now set automatically.

wiertel · 2024-09-18T11:13:43Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/HybridLinkedData.cs

+        /// <summary>
+        /// Initializes a new instance of the <see cref="HybridLinkedData"/> class.
+        /// </summary>
+        /// <param name="contactId">CBOR:"1".</param>


what are those CBORs? Could you provide something more for those parameters and properties below? or maybe it would be clear if I read the referenced specification?

Added a link to the CBOR format specification. It should be much clearer now.

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/Authenticator.cs

wiertel · 2024-09-18T12:36:37Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/Authenticator.cs

+        /// <feature>http://tizen.org/feature/security.webauthn</feature>
+        /// <exception cref="NotSupportedException">The required feature is not supported.</exception>
+        /// <exception cref="InvalidOperationException">Not allowed in the current context.</exception>
+        public static void Cancel()


In C# CancellationTokens are used to cancel ongoing operation. Maybe there is no need for that yet, and adding that mechanism can be considered in the future.

Given that the idea to convert the methods into async ones has been abandoned for now, an explicit Cancel call is needed.

wiertel · 2024-09-18T12:44:31Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/Authenticator.cs

+        /// </feature>
+        /// <param name="clientData">UTF-8 encoded JSON serialization of the client data.</param>
+        /// <param name="options">Specifies the desired attributes of the to-be-created public key credential.</param>
+        /// <param name="callbacks">The callback functions to be invoked.</param>


callbacks from native API are usually replaced with C# solutions like async/Task or events. This case is a little more complicated because there are data that should be optionally provided back to the process. Maybe a class like UserFeedbackProvider could be designed which the app developer would implement to instead, but there is not much of a benefit so let's keep this McCallbacks parameter and additionally provide the result PubkeyCredentialAttestation in a Task.

Unfortunately, the possibility of some callbacks being called multiple times makes it very difficult to convert this API into something that uses standard C# async programming. For now, we've decided to leave it as is.

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/McCallbacks.cs

wiertel · 2024-09-18T13:28:06Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/AuthenticatorAssertionResponse.cs

+        /// <summary>
+        /// JSON-compatible serialization of client data.
+        /// </summary>
+        public byte[] ClientDataJson { get; init; }


there are few fields mentioning JSON but they are still byte[], I would expect maybe not a JSON parsed object but maybe a string there, a valid Json string should fit a C# string, maybe you don't want to deal with invalid data, encoding, etc and prefer to expose raw data?

The native client is already equipped with a json parser, so any additional invalid data detection etc. on the C# side would be redundant. Given the fact that the documentation contains a link to the specification containing instructions on how the JSON should be serialized, I think it should be acceptable to simply expose the raw byte array to the user.

src/Tizen.Security.WebAuthn/doc/api/Tizen.Security.WebAuthn.md

TizenAPI-Bot · 2024-09-19T06:30:57Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 328, Removed: 20, Changed: 3

Internal API Changed

Added: 19, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.DragAndDrop/DragAndDropEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.Window,System.String,Tizen.NUI.DragAndDrop/DragAndDropWindowEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Collections.Generic.Dictionary`2<System.String,System.String> Tizen.NUI.DragData::DataMap

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String[] Tizen.NUI.DragEvent::MimeTypes()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockStateChangedEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLock Tizen.System.PowerLockStateChangedEventArgs::PowerLockType()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockState Tizen.System.PowerLockStateChangedEventArgs::PowerLockState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateChangeRequestEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.System.PowerStateChangeRequestEventArgs::Retval()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateChangeRequestEventArgs::PowerState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::NextState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::PrevState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerStateWaitEventArgs::TransitionReason()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerTransientStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientState Tizen.System.PowerTransientStateWaitEventArgs::TransientState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerTransientStateWaitEventArgs::TransitionReason()

TizenAPI-Bot · 2024-09-19T08:40:03Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 326, Removed: 20, Changed: 3

Internal API Changed

Added: 19, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.DragAndDrop/DragAndDropEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.Window,System.String,Tizen.NUI.DragAndDrop/DragAndDropWindowEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Collections.Generic.Dictionary`2<System.String,System.String> Tizen.NUI.DragData::DataMap

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String[] Tizen.NUI.DragEvent::MimeTypes()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockStateChangedEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLock Tizen.System.PowerLockStateChangedEventArgs::PowerLockType()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockState Tizen.System.PowerLockStateChangedEventArgs::PowerLockState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateChangeRequestEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.System.PowerStateChangeRequestEventArgs::Retval()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateChangeRequestEventArgs::PowerState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::NextState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::PrevState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerStateWaitEventArgs::TransitionReason()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerTransientStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientState Tizen.System.PowerTransientStateWaitEventArgs::TransientState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerTransientStateWaitEventArgs::TransitionReason()

wiertel · 2024-09-19T10:08:55Z

src/Tizen.Security.WebAuthn/doc/api/Tizen.Security.WebAuthn.md

+---
+## Overview
+It provides an [Authenticator](xref:Tizen.Security.WebAuthn.Authenticator) class containing methods for creating public key-based credentials
+([Authenticator.MakeCredential()](xref:Tizen.Security.WebAuthn.Authenticator.MakeCredential(Tizen.Security.WebAuthn.ClientData,Tizen.Security.WebAuthn.PubkeyCredCreationOptions,Tizen.Security.WebAuthn.McCallbacks))) and using them ([Authenticator.GetAssertion()](xref:Tizen.Security.WebAuthn.Authenticator.GetAssertion(Tizen.Security.WebAuthn.ClientData,Tizen.Security.WebAuthn.PubkeyCredRequestOptions,Tizen.Security.WebAuthn.GaCallbacks))). Both these operations are performed asynchronously. Callbacks passed as arguments are used to notify about the progress


please update the type name of last parameters

wiertel · 2024-09-19T10:10:09Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/GetAssertionCallbacks.cs

+        /// If the request does not need to display a QR code
+        /// then this callback function won't be invoked.
+        /// </param>
+        /// <param name="responseCallback">Callback function for getting the final response.


please break the line - the text should start on a new line

wiertel · 2024-09-19T10:10:58Z

src/Tizen.Security.WebAuthn/Tizen.Security.WebAuthn/GetAssertionCallbacks.cs

+        ///  * - proxy issues,
+        ///  * - reached the limit of credentials stored by the authenticator.


please remove those * before -, on in lines 51-52, 54-55

TizenAPI-Bot · 2024-09-19T11:20:37Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 326, Removed: 20, Changed: 3

Internal API Changed

Added: 19, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.DragAndDrop/DragAndDropEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.Window,System.String,Tizen.NUI.DragAndDrop/DragAndDropWindowEventHandler)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Collections.Generic.Dictionary`2<System.String,System.String> Tizen.NUI.DragData::DataMap

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String[] Tizen.NUI.DragEvent::MimeTypes()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockStateChangedEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLock Tizen.System.PowerLockStateChangedEventArgs::PowerLockType()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerLockState Tizen.System.PowerLockStateChangedEventArgs::PowerLockState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateChangeRequestEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.System.PowerStateChangeRequestEventArgs::Retval()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateChangeRequestEventArgs::PowerState()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::NextState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::PrevState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerStateWaitEventArgs::TransitionReason()

+ /// <since_tizen>10</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientStateWaitEventArgs

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt64 Tizen.System.PowerTransientStateWaitEventArgs::WaitCallbackId()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransientState Tizen.System.PowerTransientStateWaitEventArgs::TransientState()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.System.PowerTransitionReason Tizen.System.PowerTransientStateWaitEventArgs::TransitionReason()

Create the C# API module for WebAuthn and provide initial Interop code

Provide the signatures and documentation for the public API of the WebAuthn module and create internal helpers needed for data marshalling

- fix typos - add periods in summaries and params descriptions - change since_tizen value to 12 - move library file definitions to Interop.Libwebauthn.cs

Co-authored-by: Piotr Szydełko <[email protected]>

- API version is now set automatically on the first call. - Remove abbreviations from class names.

TizenAPI-Bot · 2024-09-19T11:58:36Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 176, Removed: 0, Changed: 0

[WebAuthn] Add WebAuthn module and public API Provide the implementation and documentation for the public API of the WebAuthn module implementing the passkey functionality. Co-authored-by: Piotr Szydełko <[email protected]>

feedop added ACR Required API12 Platform : Tizen 9.0 / TFM: net6.0-tizen9.0 labels Sep 5, 2024

feedop requested review from wiertel and terry2000s September 6, 2024 10:04

wiertel requested changes Sep 12, 2024

View reviewed changes

TizenAPI-Bot added the Internal API Changed label Sep 12, 2024

feedop requested a review from wiertel September 12, 2024 12:44

wiertel reviewed Sep 18, 2024

View reviewed changes

wiertel reviewed Sep 19, 2024

View reviewed changes

wiertel approved these changes Sep 19, 2024

View reviewed changes

Filip Skrzeczkowski and others added 9 commits September 19, 2024 13:53

Add WebAuthn module

42bb9bb

Create the C# API module for WebAuthn and provide initial Interop code

Add WebAuthn public API draft

10536a3

Provide the signatures and documentation for the public API of the WebAuthn module and create internal helpers needed for data marshalling

Add WebAuthn API implementation

3259543

[WebAuthn] ACR-related documentation improvements

0e5daef

- fix typos - add periods in summaries and params descriptions - change since_tizen value to 12 - move library file definitions to Interop.Libwebauthn.cs

[WebAuthn] Adjust native webauthn library version

de203c1

[WebAuthn] Fix user and credentials data marshalling

ff37a21

[WebAuthn] Apply code documentation enhancements

1ec684e

Co-authored-by: Piotr Szydełko <[email protected]>

[WebAuthn] Remove SetApiVersion and provide better class names

83820c4

- API version is now set automatically on the first call. - Remove abbreviations from class names.

[WebAuthn] Fix documentation formatting

d4c41a6

feedop force-pushed the webauthn branch from 09bb0c0 to d4c41a6 Compare September 19, 2024 11:53

TizenAPI-Bot removed the Internal API Changed label Sep 19, 2024

feedop merged commit 2bc29b5 into Samsung:master Sep 19, 2024
3 checks passed

feedop deleted the webauthn branch September 19, 2024 12:05

		/// Extension Identifier defined in the following registry.
		/// https://www.iana.org/assignments/webauthn/webauthn.xhtml#webauthn-extension-ids

		/// * - proxy issues,
		/// * - reached the limit of credentials stored by the authenticator.

[WebAuthn] Add WebAuthn API #6311

[WebAuthn] Add WebAuthn API #6311

Conversation

feedop commented Sep 5, 2024 • edited Loading

Description of Change

API Changes

TizenAPI-Bot commented Sep 5, 2024

Public API Changed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenAPI-Bot commented Sep 12, 2024

Public API Changed

Internal API Changed

Added

TizenAPI-Bot commented Sep 16, 2024

Public API Changed

Internal API Changed

Added

TizenAPI-Bot commented Sep 17, 2024

Public API Changed

Internal API Changed

Added

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenAPI-Bot commented Sep 19, 2024

Public API Changed

Internal API Changed

Added

TizenAPI-Bot commented Sep 19, 2024

Public API Changed

Internal API Changed

Added

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenAPI-Bot commented Sep 19, 2024

Public API Changed

Internal API Changed

Added

TizenAPI-Bot commented Sep 19, 2024

Public API Changed

feedop commented Sep 5, 2024 •

edited

Loading