TESTCODE #6416
Closed
TESTCODE #6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WebRTC] Change state restriction
- NUI Autofill code was not removed together with dali ones. - Now, all related codes should be deleted because there's no use case anywhere and they don't have their internal implementation. Signed-off-by: Seoyeon Kim <[email protected]>
… is cleared. (Samsung#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/
- `CSharp_Dali_ViewImpl_AccessibilityActivate` was removed in 2018 lol
However, at that time, NUI codes couldn't be removed together (Not sure)
- The reason `ViewImpl_AccessibilityActivate` was removed is
`Remove functions which using internal apis
Some binding functions use internal apis.
It caused error when dlopen csharp binder.`
- User can use Activated event with `View.AccessibilityActivated`
Signed-off-by: Seoyeon Kim <[email protected]>
System.Reflection.Assembly.CreateInstance() can return null value. Signed-off-by: Sangyoon Jang <[email protected]>
This patch changes internal tensor size limit in MachineLearning.Inference. Tizen Native ML api's max tensor size has been changed to 256. Signed-off-by: Yelin Jeong <[email protected]>
Let we support to BoxShadow and ColorVisual, to ignore rendering inside of View area. None is default, same as previous logics. CutoutView is cutout render area as bounding box of view. It is faster than CutoutViewWithCornerRadius. CutoutWithCornerRadius is cutout render area consider the corner radius of view. Required dali patch : https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/314255 Signed-off-by: Eunki, Hong <[email protected]>
- Make intention revealing names for Some variables. Choosing names that reveal intent can make it much easier to understand. Signed-off-by: Seoyeon Kim <[email protected]>
this patch supports cornerRadius in WebView refer to : https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/304770/
Signed-off-by: Seungho Baek <[email protected]>
Use this when you want to know the status value of a pan gesture. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-core/+/315444/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/315445/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/315446/
Since some useless animation was running internally until GC comes, CPU usage might be increased for this sample. To avoid useless rendering, let we ensurely dispose not-using animation. Signed-off-by: Eunki, Hong <[email protected]>
Make we use unified code style when we connect/disconnect native signal to C# EventHandler. It will be reduce some copy-paste the non-common style implementation. This PR will change below classes * (internal)Application and it's family * (internal)ObjectRegistry * (internal)Builder * (internal)GaussianBlurView * ImageView and it's family * View, ViewAccessibility * Clipboard * Capture Signed-off-by: Eunki, Hong <[email protected]>
Signed-off-by: Seungho Baek <[email protected]>
Co-authored-by: Woochan Lee <[email protected]>
- TCT crash issue, log => E/STDERR (21795): Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object. E/STDERR (21795): at Tizen.NUI.BaseComponents.View.Dispose(DisposeTypes type) in Tizen.NUI.dll:token 0x6002b7c+0x591 E/STDERR (21795): at Tizen.NUI.BaseHandle.Dispose() in Tizen.NUI.dll:token 0x6000e5c+0xc E/STDERR (21795): at Tizen.NUI.DisposeQueue.ProcessDisposablesIncrementally() in Tizen.NUI.dll:token 0x6000238+0x79 E/STDERR (21795): at Tizen.NUI.DisposeQueue.ProcessDisposables() in Tizen.NUI.dll:token 0x6000237+0xd5 E/STDERR (21795): onSigabrt called
…view Until now, VisibilityChangedEventArgs.View return sender itself. It is useless information for user. Follow up some other platform's behavior, ( reference : https://developer.android.com/reference/android/view/View#onVisibilityChanged(android.view.View,%20int) ) Let we make VisibilityChangedEventArgs.View return visibility changed view. Relative dali patch : - https://review.tizen.org/gerrit/c/platform/core/uifw/dali-core/+/315475 - https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/315484 Signed-off-by: Eunki, Hong <[email protected]>
Found some build warning list by below command dotnet build /p:BuildWithAnalyzer=True -consoleloggerparameters:NoSummary Their are too many warnings occurs, let we remove them by multiple phases. Signed-off-by: Eunki, Hong <[email protected]>
Apply some comments that report at PR Samsung#6079 - `Color.A` getter apply `Opacity` changeness - Make `VisualFittingMode` have no effect for `ColorVisual` and `BorderVisual` - `GetVisualProperty` return valid value after call `GetCurrentVisualProperty` - Make `VisualBase` class as abstract. Let we don't allow to call this class constructor. Signed-off-by: Eunki, Hong <[email protected]>
Add SynchrousSizing property - reload as size of visual. It will be useful when we want to load image as specific size of view, so the memory is reduced. Signed-off-by: Eunki Hong <[email protected]>
Signed-off-by: Seoyeon Kim <[email protected]>
…nterface across different modules
Add more detailed APIs description. Signed-off-by: Yunhee Seo <[email protected]>
Co-authored-by: Eunki Hong <[email protected]>
Co-authored-by: Eunki Hong <[email protected]>
Let we make some class that could create NativeImageSource / NativeImageQueue with raw-buffer-handle of tbm_surface_h / tbm_queue_h. It will be used for some advanced tizen platform developer. Relative dali patch : https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/318356 Signed-off-by: Eunki, Hong <[email protected]>
Adds implementations and samples for WidgetComponent use For more information, please refer to the links below - Tizen.Applications.ComponentBased: https://github.com/Samsung/TizenFX/tree/master/src/Tizen.Applications.ComponentBased - Tizen.Applications.ComponentBased.Default: https://github.com/Samsung/TizenFX/tree/master/src/Tizen.Applications.ComponentBased.Default/Tizen.Applications.ComponentBased.Default - EFL Sample app: https://github.sec.samsung.net/appfw/csharp-component-based-app
Signed-off-by: Eunki, Hong <[email protected]>
Relative dali patch : https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/318377 https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/318385 Signed-off-by: Eunki, Hong <[email protected]>
Since protected level make runtime error for TV FLUX project, let we revert it as internal again. Signed-off-by: Eunki, Hong <[email protected]>
Signed-off-by: Jaechul Lee <[email protected]>
…ng#6402) ACR: https://jira.sec.samsung.net/browse/TCSACR-603 Co-authored-by: randeepsingh01 <[email protected]>
There were issues with heap use after free and heap overflow occurring (TNINE-4152, 4153, 4154). In order to solve this problem, modified the internal logic of the API. Signed-off-by: SeoHyungjun <[email protected]>
- fix the crash issue : A callback was made on a garbage collected delegate of type 'Tizen.NUI!Tizen.NUI.WebContext+WebContextHttpRequestInterceptedProxyCallback::Invoke'
1) DF240922-00003 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=43585 false alarm At line 755, a null check has been already performed ; the item "e.Proposed" which was pointed out as an problem cannot become null. As such, this issue does not require correction as it is a false alarm. 2) DF240907-00723 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=176282 fixed 3) DF240907-00695 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=176248 fixed 4) DF240906-00277 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=174470 fixed 5) DF240905-01180 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=43601 At line 1014, a null check has been already performed; if it is null, an exception will be thrown. Therefore, at line 1018, the item which was pointed out as an problem cannot become null. As such, this issue does not require correction as it is a false alarm. 6) DF240821-00053 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=163282 fixed 7) DF240716-01912 https://sa.sec.samsung.net/dm/tizen90/sb2/main/review#PRJID=1&WGID=163084 already fixed in the previous patch
Since dali_2.3.41, MixColor property animate by Vector4 type. But NUI animation property helper doesn't apply those changeness. To match the previous behavior, let we make BackgroundColor and BoxShadow.Color animate by Color class well. Signed-off-by: jmm <[email protected]>
Signed-off-by: Eunki, Hong <[email protected]>
Public API ChangedPlease follow the ACR process for the changed API below. |
JoogabYun
force-pushed
the
PenWave_1016
branch
from
4935241
to
1f3c223
Compare
Public API ChangedPlease follow the ACR process for the changed API below. |
JoogabYun
force-pushed
the
PenWave_1016
branch
from
1f3c223
to
fae2439
Compare
Public API ChangedPlease follow the ACR process for the changed API below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
API Changes