Improved theme initialization and refactored auth logic #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SankethBK
reviewed
Oct 28, 2024
| return BlocBuilder<FontCubit, FontState>( | ||
| builder: (context, fontState) { | ||
| return MaterialApp( | ||
| navigatorKey: _navigatorKey, |
There was a problem hiding this comment.
The performance gain may not be worth the nested widget BlocBuilders. These bloc's rarely change, so its better to preserve readability here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR refines the theme initialization and authentication navigation in the app. The changes aim to improve readability, maintainability, and efficiency by consolidating logic and simplifying navigation flows.
Features Covered in this PR
Related Tickets & Documents
Screenshots, Recordings
Attach screenshots or recordings if your PR affects the UI or user experience.
Tested Feature