Remove most instances of VCR skips referencing hashicorp/terraform-pr…

…ovider-google#14158
SarahFrench · Aug 29, 2024 · c3b8b17 · c3b8b17
1 parent 929316b
commit c3b8b17
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 20 deletions.
diff --git a/mmv1/third_party/terraform/fwprovider/framework_provider_test.go.erb b/mmv1/third_party/terraform/fwprovider/framework_provider_test.go.erb
@@ -18,8 +18,6 @@ import (
 )
 
 func TestAccFrameworkProviderMeta_setModuleName(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	moduleName := "my-module"
@@ -64,8 +62,6 @@ func TestAccFrameworkProviderBasePath_setInvalidBasePath(t *testing.T) {
 }
 
 func TestAccFrameworkProviderBasePath_setBasePath(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	acctest.VcrTest(t, resource.TestCase{

diff --git a/mmv1/third_party/terraform/fwprovider/go/framework_provider_test.go.tmpl b/mmv1/third_party/terraform/fwprovider/go/framework_provider_test.go.tmpl
@@ -17,8 +17,6 @@ import (
 )
 
 func TestAccFrameworkProviderMeta_setModuleName(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	moduleName := "my-module"
@@ -63,8 +61,6 @@ func TestAccFrameworkProviderBasePath_setInvalidBasePath(t *testing.T) {
 }
 
 func TestAccFrameworkProviderBasePath_setBasePath(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	acctest.VcrTest(t, resource.TestCase{

diff --git a/...ty/terraform/services/firebase/data_source_google_firebase_android_app_config_test.go.erb b/...ty/terraform/services/firebase/data_source_google_firebase_android_app_config_test.go.erb
@@ -12,8 +12,6 @@ import (
 
 func TestAccDataSourceGoogleFirebaseAndroidAppConfig(t *testing.T) {
 	t.Parallel()
-	// Framework-based resources and datasources don't work with VCR yet
-	acctest.SkipIfVcr(t)
 
 	context := map[string]interface{}{
 		"project_id":   envvar.GetTestProjectFromEnv(),

diff --git a/...arty/terraform/services/firebase/data_source_google_firebase_apple_app_config_test.go.erb b/...arty/terraform/services/firebase/data_source_google_firebase_apple_app_config_test.go.erb
@@ -11,8 +11,6 @@ import (
 )
 
 func TestAccDataSourceGoogleFirebaseAppleAppConfig(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	context := map[string]interface{}{

diff --git a/...erraform/services/firebase/go/data_source_google_firebase_android_app_config_test.go.tmpl b/...erraform/services/firebase/go/data_source_google_firebase_android_app_config_test.go.tmpl
@@ -11,8 +11,6 @@ import (
 
 func TestAccDataSourceGoogleFirebaseAndroidAppConfig(t *testing.T) {
 	t.Parallel()
-	// Framework-based resources and datasources don't work with VCR yet
-	acctest.SkipIfVcr(t)
 
 	context := map[string]interface{}{
 		"project_id":   envvar.GetTestProjectFromEnv(),

diff --git a/.../terraform/services/firebase/go/data_source_google_firebase_apple_app_config_test.go.tmpl b/.../terraform/services/firebase/go/data_source_google_firebase_apple_app_config_test.go.tmpl
@@ -10,8 +10,6 @@ import (
 )
 
 func TestAccDataSourceGoogleFirebaseAppleAppConfig(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	context := map[string]interface{}{

diff --git a/mmv1/third_party/terraform/services/firebase/go/resource_firebase_web_app_test.go.tmpl b/mmv1/third_party/terraform/services/firebase/go/resource_firebase_web_app_test.go.tmpl
@@ -16,8 +16,6 @@ import (
 )
 
 func TestAccFirebaseWebApp_firebaseWebAppFull(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	context := map[string]interface{}{

diff --git a/mmv1/third_party/terraform/services/firebase/resource_firebase_web_app_test.go.erb b/mmv1/third_party/terraform/services/firebase/resource_firebase_web_app_test.go.erb
@@ -17,8 +17,6 @@ import (
 )
 
 func TestAccFirebaseWebApp_firebaseWebAppFull(t *testing.T) {
-	// TODO: https://github.com/hashicorp/terraform-provider-google/issues/14158
-	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	context := map[string]interface{}{