Warnings removals and python 3.9 drop in tests #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
wpotrzebowski
changed the title
krzywon
reviewed
Apr 25, 2024
rozyczko
approved these changes
Apr 26, 2024
| with: | ||
| name: SasView-Installer-${{ matrix.os }}-${{ matrix.python-version }} | ||
| path: | | ||
| installers/dist/setupSasView.exe | ||
| installers/dist/SasView6.dmg | ||
| installers/dist/sasview6.tar.gz | ||
| if-no-files-found: error | ||
| if-no-files-found: ignore |
There was a problem hiding this comment.
Is this a good idea? Shouldn't the build be marked failed if the installer is not present?
There was a problem hiding this comment.
Yeah, the problem with this one is that action only sees the current OS installer (e.g. Windows runner doesn't produce OSX installer). If one want to do it properly, we will probably have to split it into 3 actions and I considered doing that. However, the "error" only seems to throw the warning and it still proceeds the build. Therefore "ignoring" seems to be pragmatic solution here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is now down to one warning, which cannot easily be fixed due to dependent action.
Removing warnings created by GH actions and dropping support for python 3.9 in tests (as it seems to be not available on
latest-macosrunners actions/setup-python#850)