Add missed a slash in SAVE_PATH #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SathyaBhat
reviewed
Dec 2, 2021
| @@ -7,4 +7,4 @@ | |||
| if os.getenv("XDG_CACHE_HOME") is not None: | |||
| SAVE_PATH = os.getenv("XDG_CACHE_HOME") + "/spotifydl" | |||
| else: | |||
| SAVE_PATH = os.getenv("HOME") + ".cache/spotifydl" | |||
| SAVE_PATH = os.getenv("HOME") + "/.cache/spotifydl" | |||
There was a problem hiding this comment.
we should ideally be using PathLib to make it crossplatform compatible
SathyaBhat
referenced
this pull request
Jan 10, 2022
I think the best idea is to store non-essential files (that can be deleted without harm) in XDG_CACHE_HOME, as required by the XDG Base Directory specification. See https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html For systems that do not have this environment variable by default, can use ${HOME}/.cache. This will help reduce the number of directories in the user's home directory.
judaew
added a commit
to macports/macports-ports
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #226 (comment)