Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor fixes #377

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Two minor fixes #377

merged 3 commits into from
Jul 12, 2024

Conversation

Maritsu
Copy link
Contributor

@Maritsu Maritsu commented Jul 11, 2024

I'm somewhat ashamed to have made such a trivial oversight, but yet here I am. This PR:

On top of that, included is a fix for Maritsu@e05d9e4#commitcomment-144139425 (shutil.SameFileError when moving reference log).

Copy link

sentry-io bot commented Jul 11, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: spotify_dl/youtube.py

Function Unhandled Issue
download_songs SameFileError: 'download_list.log' and './download_list.log' are the same file spotif...
Event Count: 6
download_songs ValueError: not enough values to unpack (expected 2, got 0) spotify_dl.youtube in find_and_dow...
Event Count: 2
download_songs NameError: name 'd' is not defined spotify_dl.you...
Event Count: 2
download_songs FileNotFoundError: [Errno 2] No such file or directory: './download_list.log' spotify_dl.youtu...
Event Count: 2
download_songs NameError: name 'size' is not defined spotify_dl....
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@SathyaBhat
Copy link
Owner

all good mate no worries and thanks for the fix @Maritsu

@SathyaBhat SathyaBhat merged commit e74a4d4 into SathyaBhat:master Jul 12, 2024
5 of 6 checks passed
@Maritsu Maritsu deleted the two-fixes branch July 12, 2024 08:59
Copy link

sentry-io bot commented Jul 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IndexError: list index out of range spotify_dl.youtube in <lambda> View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants