Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: useValue + useClass injectables #81

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Conversation

Sorikairox
Copy link
Collaborator

Description

Sometimes, we want to inject a plain object (such as a configuration object). useValue does that.

I remove TokenInjector to stay consistent.


Issue Ticket Number

Fixes #(issue_number)


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run deno lint AND deno fmt AND deno task test and got no
    errors.
  • I have followed the contributing guidelines of this project as mentioned
    in CONTRIBUTING.md
  • I have checked to ensure there aren't other open
    Pull Requests for the same
    update/change?
  • I have performed a self-review of my own code
  • I have made corresponding changes needed to the documentation

@Sorikairox Sorikairox self-assigned this Feb 22, 2024
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🙌
Friendly reminder to update the docs 😁

spec/scoped-lifecycle-hook-another-order.test.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.52239% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.56%. Comparing base (cc251f0) to head (3c8ba33).

❗ Current head 3c8ba33 differs from pull request most recent head a4eef8e. Consider uploading reports for the commit a4eef8e to get more accurate results

Files Patch % Lines
src/module/decorator.ts 0.00% 2 Missing ⚠️
src/injector/injector.ts 97.95% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   87.53%   87.56%   +0.02%     
==========================================
  Files          59       58       -1     
  Lines        1781     1801      +20     
  Branches      181      183       +2     
==========================================
+ Hits         1559     1577      +18     
- Misses        220      221       +1     
- Partials        2        3       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sorikairox Sorikairox merged commit c10ab66 into main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants